deps: update ChakraCore to chakra-core/ChakraCore@5d123b4b51

[1.8>1.9] [MERGE #4649 @MikeHolman] fix bad register use in asm.js thunk

Merge pull request #4649 from MikeHolman:asmthunk

OS: 15151031

Reviewed-By: chakrabot <[email protected]>

Author: MikeHolman

Diff for: deps/chakrashim/core/lib/Runtime/Library/JavascriptFunction.cpp

@@ -1163,13 +1163,14 @@ namespace Js
         __asm
         {
             mov savedEsp, esp;
-            mov eax, argsSize;
-            cmp eax, 0x1000;
+            mov ecx, argsSize;
+            cmp ecx, 0x1000;
             jl allocate_stack;
             // Use _chkstk to probe each page when using more then a page size
-            call _chkstk;
-allocate_stack:
-            sub esp, eax;
+            mov eax, ecx;
+            call _chkstk; // _chkstk saves/restores ecx
+        allocate_stack:
+            sub esp, ecx;
 
             mov edi, esp;
             mov esi, argv;

Diff for: deps/chakrashim/core/test/AsmJs/manyargs.js

@@ -0,0 +1,28 @@
+//-------------------------------------------------------------------------------------------------------
+// Copyright (C) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
+//-------------------------------------------------------------------------------------------------------
+
+let str = `(function module() { "use asm";function foo(`;
+// 550 double args exceeds 1 page
+const totalArgs = 550
+for (let i = 0; i < totalArgs; ++i)
+{
+    str += `arg${i},`;
+}
+str += `arg${totalArgs}){`;
+
+for (let i = 0; i <= totalArgs; ++i)
+{
+    str += `arg${i}=+arg${i};`;
+}
+str += "return 10;}function bar(){return foo(";
+for (let i = 0; i < totalArgs; ++i)
+{
+    str += "0.0,";
+}
+str += "1.0)|0;}"
+str += "return bar})()()";
+
+const result = eval(str);
+print(result == 10 ? "Pass" : `Fail: ${result}`);

Diff for: deps/chakrashim/core/test/AsmJs/rlexe.xml

@@ -1043,6 +1043,11 @@
       <files>argassignbug.js</files>
     </default>
   </test>
+  <test>
+    <default>
+      <files>manyargs.js</files>
+    </default>
+  </test>
   <test>
     <default>
       <files>maybecallbug.js</files>