Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol::WellKnown fails in Object::CheckCast when NODE_ADDON_API_ENABLE_TYPE_CHECK_ON_AS is defined #1575

Closed
swwilson-bsi opened this issue Sep 6, 2024 · 1 comment · Fixed by #1581
Assignees

Comments

@swwilson-bsi
Copy link

Define NODE_ADDON_API_ENABLE_TYPE_CHECK_ON_AS
Do not define NODE_ADDON_API_ENABLE_MAYBE
Symbol::WellKnown calls Napi::Env(env).Global().Get("Symbol").As().
That will trigger a fatal error because napi_typeof(Symbol) returns napi_function, not napi_object.

@mhdawson
Copy link
Member

mhdawson commented Sep 6, 2024

@legendecas mentioned in the meeting today that we should add testing with the most strick options and that he'll take a look at that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants