Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NODE_API_SWALLOW_UNTHROWABLE_EXCEPTIONS only catch one throw #1027

Closed
JsBlueCat opened this issue Jul 24, 2021 · 3 comments
Closed

NODE_API_SWALLOW_UNTHROWABLE_EXCEPTIONS only catch one throw #1027

JsBlueCat opened this issue Jul 24, 2021 · 3 comments

Comments

@JsBlueCat
Copy link

use NODE_API_SWALLOW_UNTHROWABLE_EXCEPTIONS in defines will solve one throw problem.

but if do another throw, the node-addon-api will be crashed

@KevinEady
Copy link
Contributor

Hello,

We took a look at this in today's Node.js API meeting, and just and FYI this change was introduced via #975

@github-actions
Copy link
Contributor

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@gabrielschulhof
Copy link
Contributor

@JsBlueCat can you please try release 4.0.0 or later of node-addon-api and tell us whether you still see this issue and re-open it if you do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants