Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'request' packages is not used? #872

Open
ip1981 opened this issue Oct 12, 2019 · 1 comment
Open

The 'request' packages is not used? #872

ip1981 opened this issue Oct 12, 2019 · 1 comment

Comments

@ip1981
Copy link

ip1981 commented Oct 12, 2019

There is a dev dependency in package.json - "request": "=2.81.0", but I don't see it's used anywhere.

@bnoordhuis
Copy link
Member

That's to pin down the version of request that's used by node-gyp. There was a change in [email protected] that breaks old Node.js versions. See commit 4525cbc.

As a node-gyp maintainer, I'd say depending on a specific version of node-gyp rather than what is shipped with npm is kind of an anti-pattern but hey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants