Skip to content
This repository has been archived by the owner on Nov 21, 2018. It is now read-only.

Use version number placeholders in content #220

Closed
fhemberger opened this issue Feb 20, 2015 · 10 comments
Closed

Use version number placeholders in content #220

fhemberger opened this issue Feb 20, 2015 · 10 comments

Comments

@fhemberger
Copy link
Contributor

After just pushing #219, can we please add placeholders in the content files for:

  • io.js version number
  • V8 version number used in io.js
  • V8 version number used in Node.js (see ES6 page)
  • Node.js (stable) version number (see ES6 page)

Those should be replaced during the build process, so we don't need to touch every single translation, updating every single download link for each platform with a new release.

@AntouanK
Copy link
Contributor

Happy to work on that, if the WG members agree.

@Fishrock123
Copy link
Contributor

Yeah, plan was to do this from the start, except it would read an external json when available, and default to a local one for testing.

@AntouanK
Copy link
Contributor

Exactly, a JSON should be enough to hold the versions and their string/URL representations.
Should be easy reading it in gulp and injecting it into the md files.

@therebelrobot
Copy link
Contributor

+1 to this. Feel free to PR @AntouanK

@AntouanK
Copy link
Contributor

@therebelrobot I have an open PR for that

@parroit
Copy link
Contributor

parroit commented Feb 24, 2015

👍 really useful

@snostorm
Copy link
Contributor

snostorm commented Mar 1, 2015

See #251 for some movement on this

@snostorm
Copy link
Contributor

snostorm commented Mar 1, 2015

Things like URLs should also be generating dynamically. Really the whole index.md file should probably be retired with something .json powered. Although #251 has a little bit of this now, consider it an ongoing evolution. (#251 was a quick improvement, not necessarily the final solution.)

@Fishrock123
Copy link
Contributor

#251 fixed the version number issue.

We didn't do node version numbers yet, but we can just do that when a release comes out from there, or if someone wants to spend a few minutes doing it.

@snostorm
Copy link
Contributor

I thought I closed this a long time ago. Good call. Looks like @Fishrock123 and I are both doing some spring cleaning today. Perhaps our differing sort options are keeping us from bumping in to each other's issue closings ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants