Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove traceSyncIO from process #2143

Closed
wants to merge 1 commit into from

Conversation

bmeck
Copy link
Member

@bmeck bmeck commented Jul 9, 2015

this is unnecessary as per @trevnorris

@bmeck bmeck mentioned this pull request Jul 9, 2015
@evanlucas
Copy link
Contributor

I would be curious to see if anyone (not sure why?) is actually using this though. It seems to me like this would be a semver-major change if that is the case.

@mscdex mscdex added c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem. labels Jul 9, 2015
@trevnorris
Copy link
Contributor

LGTM

This property was added not that long ago by myself, and shouldn't have been. I don't see a conceivable way this could break any modules. If it does then we can add it back and wait for a major.

@evanlucas
Copy link
Contributor

works for me LGTM

@bnoordhuis
Copy link
Member

Pile-on LGTM.

bnoordhuis pushed a commit that referenced this pull request Jul 9, 2015
PR-URL: #2143
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
@bnoordhuis
Copy link
Member

Thanks, landed in 5ee4881.

@bnoordhuis bnoordhuis closed this Jul 9, 2015
bnoordhuis pushed a commit that referenced this pull request Jul 9, 2015
PR-URL: #2143
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
mscdex pushed a commit to mscdex/io.js that referenced this pull request Jul 9, 2015
PR-URL: nodejs#2143
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants