-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add chalker as collaborator #1927
Conversation
LGTM |
Updated to the actual gitconfig name (as suggested in IRC) and GitHub username. |
LGTM and welcome aboard. |
LGTM! |
That's the first fully non-ascii name we'll have in README. Is everybody okay with that? |
Yeah, it's probably better to have it transliterated |
I asked in the IRC about that and said that I could take one of two options for everything to match:
I was told (in IRC) by @bnoordhuis that the first variant should be preferred because of that's how it is mentioned the git history already. I will hold off merging this until more people review this. |
@vkurchatkin It was initially transliterated in this PR, I was told not to. |
What's the counter argument against cyrillic? I don't have a strong opinion for either but the history reference @bnoordhuis brought up makes sense to me. |
People who aren't familiar with the language won't be able to read it, figure out how to pronounce it, and check if it's been copy-pasted to |
+1 |
@rlidwka @vkurchatkin Just for reference:
Copy-pasting and checking the «Reviewed-By» field was the reason why I was asked to use a single variant everywhere, and this is why I changed the original PR in the first place. |
I'm not sure, I'm ok with having Cyrillic / etc character names in the readme, although, I would prefer something I can begin to pronounce. :) Perhaps a compromise could be made where we have: |
I am ok with it – those of us who can't read it can always copy-paste it, or this might be a good motivator for us to pick up Cyrillic! :) |
I'd go for both cyrillic and translated version like @Fishrock123 suggests. |
I'm not a fan of keeping this PR (which is supposed to be the welcoming step) open for a slightly different discussion than what the PR itself accomplishes. I count enough LGTM's to merge -- how about we open a discussion elsewhere for improving README.md (and/or .gitconfig) in terms of i18n? |
+1 for @jbergstroem. Collaborator PRs are more symbolic, not really a place for this sort of discussion. Anyways.. if we want to get technical and argue, other alphabets around the world carry letters and sounds that don't have English / Latinized equivalents. The "Latinize everything" approach wouldn't scale to lots of languages - just because Cyrillic is comparably similar doesn't mean we should make our decision based only off of this. (oh, and Cyrillic is easy to learn 😉) |
Using the non-transliterated name as requested. The transliteration is "Nikita Skovoroda" (first and last name), if anyone will want to organize non-ASCII names. PR-URL: nodejs#1927 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Chris Dickinson <[email protected]>
Ok, I am merging this as it is now, marking this as reviewed by people who reviewed the current version. |
PR-URL: #1927