Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add chalker as collaborator #1927

Merged
merged 1 commit into from
Jun 13, 2015
Merged

Conversation

ChALkeR
Copy link
Member

@ChALkeR ChALkeR commented Jun 9, 2015

PR-URL: #1927

@Fishrock123
Copy link
Contributor

LGTM

@ChALkeR
Copy link
Member Author

ChALkeR commented Jun 9, 2015

Updated to the actual gitconfig name (as suggested in IRC) and GitHub username.
/cc @jbergstroem

@mscdex mscdex added the doc Issues and PRs related to the documentations. label Jun 9, 2015
@bnoordhuis
Copy link
Member

LGTM and welcome aboard.

@jbergstroem
Copy link
Member

LGTM!

@rlidwka
Copy link
Contributor

rlidwka commented Jun 9, 2015

That's the first fully non-ascii name we'll have in README. Is everybody okay with that?

@vkurchatkin
Copy link
Contributor

Yeah, it's probably better to have it transliterated

@ChALkeR
Copy link
Member Author

ChALkeR commented Jun 9, 2015

@rlidwka

I asked in the IRC about that and said that I could take one of two options for everything to match:

  1. Use the cyrillic full name for the Readme.md (as the one that is in AUTHORS, GitHub profile and commits). This does not match with how other collabolators are listed.
  2. Use the transliterated variant (as was initially in this PR), change it in AUTHORS with the same commit, and set it in the local git config. This will not match with GitHub profile and my commits to all other projects (both GitHub-hosted and not).

I was told (in IRC) by @bnoordhuis that the first variant should be preferred because of that's how it is mentioned the git history already.

I will hold off merging this until more people review this.

@ChALkeR
Copy link
Member Author

ChALkeR commented Jun 9, 2015

@vkurchatkin It was initially transliterated in this PR, I was told not to.
Delaying merging until a consensus is reached.

@jbergstroem
Copy link
Member

What's the counter argument against cyrillic? I don't have a strong opinion for either but the history reference @bnoordhuis brought up makes sense to me.

@rlidwka
Copy link
Contributor

rlidwka commented Jun 9, 2015

What's the counter argument against cyrillic?

People who aren't familiar with the language won't be able to read it, figure out how to pronounce it, and check if it's been copy-pasted to Reviewed-By correctly. I don't know how much of an issue it is, just pointing it out.

@vkurchatkin
Copy link
Contributor

People who aren't familiar with the language won't be able to read it, figure out how to pronounce it, and check if it's been copy-pasted to Reviewed-By correctly. I don't know how much of an issue it is, just pointing it out.

+1

@ChALkeR
Copy link
Member Author

ChALkeR commented Jun 9, 2015

@rlidwka @vkurchatkin Just for reference:

and check if it's been copy-pasted to Reviewed-By correctly.

Copy-pasting and checking the «Reviewed-By» field was the reason why I was asked to use a single variant everywhere, and this is why I changed the original PR in the first place.

@Fishrock123
Copy link
Contributor

I'm not sure, I'm ok with having Cyrillic / etc character names in the readme, although, I would prefer something I can begin to pronounce. :)

Perhaps a compromise could be made where we have:
**full name** _(Transliterated)_ [@username]()?

@chrisdickinson
Copy link
Contributor

That's the first fully non-ascii name we'll have in README. Is everybody okay with that?

I am ok with it – those of us who can't read it can always copy-paste it, or this might be a good motivator for us to pick up Cyrillic! :)

@tellnes
Copy link
Contributor

tellnes commented Jun 10, 2015

I'd go for both cyrillic and translated version like @Fishrock123 suggests.

@jbergstroem
Copy link
Member

I'm not a fan of keeping this PR (which is supposed to be the welcoming step) open for a slightly different discussion than what the PR itself accomplishes. I count enough LGTM's to merge -- how about we open a discussion elsewhere for improving README.md (and/or .gitconfig) in terms of i18n?

@brendanashworth
Copy link
Contributor

+1 for @jbergstroem. Collaborator PRs are more symbolic, not really a place for this sort of discussion.

Anyways.. if we want to get technical and argue, other alphabets around the world carry letters and sounds that don't have English / Latinized equivalents. The "Latinize everything" approach wouldn't scale to lots of languages - just because Cyrillic is comparably similar doesn't mean we should make our decision based only off of this. (oh, and Cyrillic is easy to learn 😉)

Using the non-transliterated name as requested.

The transliteration is "Nikita Skovoroda" (first and last name),
if anyone will want to organize non-ASCII names.

PR-URL: nodejs#1927
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Chris Dickinson <[email protected]>
@ChALkeR
Copy link
Member Author

ChALkeR commented Jun 13, 2015

Ok, I am merging this as it is now, marking this as reviewed by people who reviewed the current version.
I changed the commit message, so if there will be a future consensus on how to write non-ASCII names, the transliterated name could be taken from there.

@ChALkeR ChALkeR merged commit 4285265 into nodejs:master Jun 13, 2015
@ChALkeR ChALkeR deleted the collaborator branch June 13, 2015 07:35
@rvagg rvagg mentioned this pull request Jun 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants