test: remove hardwired references to 'iojs' #1882
Conversation
| @@ -25,7 +26,7 @@ exec('ps -p ' + process.pid + ' -o args=', function(error, stdout, stderr) { | |||
| assert.equal(stderr, ''); | |||
|
|
|||
| // freebsd always add ' (procname)' to the process title | |||
| if (process.platform === 'freebsd') title += ' (iojs)'; | |||
| if (process.platform === 'freebsd') `${title} (${path.basename(process.execPath)})`; | |||
There was a problem hiding this comment.
This turns it into a no-op, doesn't it?
There was a problem hiding this comment.
why yes, yes it does .. fixed, thanks
| @@ -25,7 +26,7 @@ exec('ps -p ' + process.pid + ' -o args=', function(error, stdout, stderr) { | |||
| assert.equal(stderr, ''); | |||
|
|
|||
| // freebsd always add ' (procname)' to the process title | |||
| if (process.platform === 'freebsd') title += ' (iojs)'; | |||
| if (process.platform === 'freebsd') title += ` (${path.basename(process.execPath)})`; | |||
|
LGTM sans style nit. Didn't |
|
pffft, seriously .. I forget to run it, and it's still not in CI |
|
fixed btw |
|
I run |
|
Linting is part of |
|
|
| @@ -25,7 +26,8 @@ exec('ps -p ' + process.pid + ' -o args=', function(error, stdout, stderr) { | |||
| assert.equal(stderr, ''); | |||
|
|
|||
| // freebsd always add ' (procname)' to the process title | |||
| if (process.platform === 'freebsd') title += ' (iojs)'; | |||
| if (process.platform === 'freebsd') | |||
| title += ` (${path.basename(process.execPath)})`; | |||
There was a problem hiding this comment.
This will append .exe on Windows. I say just change it to node or do something like this.
There was a problem hiding this comment.
process.platform can't be 'freebsd' on Windows
|
LGTM |
PR-URL: #1882 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
|
Test failures were unrelated, landed in f78c722 |
PR-URL: nodejs/node#1882 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
there shouldn't be any references to 'iojs' in the tests (or 'node' either, but they were mostly taken care of already)