-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove hardwired references to 'iojs' #1882
Conversation
@@ -25,7 +26,7 @@ exec('ps -p ' + process.pid + ' -o args=', function(error, stdout, stderr) { | |||
assert.equal(stderr, ''); | |||
|
|||
// freebsd always add ' (procname)' to the process title | |||
if (process.platform === 'freebsd') title += ' (iojs)'; | |||
if (process.platform === 'freebsd') `${title} (${path.basename(process.execPath)})`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This turns it into a no-op, doesn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why yes, yes it does .. fixed, thanks
@@ -25,7 +26,7 @@ exec('ps -p ' + process.pid + ' -o args=', function(error, stdout, stderr) { | |||
assert.equal(stderr, ''); | |||
|
|||
// freebsd always add ' (procname)' to the process title | |||
if (process.platform === 'freebsd') title += ' (iojs)'; | |||
if (process.platform === 'freebsd') title += ` (${path.basename(process.execPath)})`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Long line.
LGTM sans style nit. Didn't |
pffft, seriously .. I forget to run it, and it's still not in CI |
fixed btw |
I run |
Linting is part of |
|
@@ -25,7 +26,8 @@ exec('ps -p ' + process.pid + ' -o args=', function(error, stdout, stderr) { | |||
assert.equal(stderr, ''); | |||
|
|||
// freebsd always add ' (procname)' to the process title | |||
if (process.platform === 'freebsd') title += ' (iojs)'; | |||
if (process.platform === 'freebsd') | |||
title += ` (${path.basename(process.execPath)})`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will append .exe
on Windows. I say just change it to node
or do something like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
process.platform
can't be 'freebsd'
on Windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right 😅
LGTM |
PR-URL: #1882 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Test failures were unrelated, landed in f78c722 |
PR-URL: nodejs/node#1882 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
there shouldn't be any references to 'iojs' in the tests (or 'node' either, but they were mostly taken care of already)