Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unneeded comment task #1858

Closed
wants to merge 1 commit into from
Closed

test: remove unneeded comment task #1858

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 1, 2015

The test queried about in the TODO comment would result in a HTTP request to localhost and falls outside of the scope of the test file in which it appears, which tests that protocols other than HTTP and HTTPS throw errors.

ref: #264

@brendanashworth brendanashworth added the test Issues and PRs related to the tests. label Jun 1, 2015
@cjihrig
Copy link
Contributor

cjihrig commented Jun 1, 2015

LGTM

brendanashworth pushed a commit that referenced this pull request Jun 1, 2015
@brendanashworth
Copy link
Contributor

Thanks Rich, landed in 8704c58.

andrewdeandrade pushed a commit to andrewdeandrade/node that referenced this pull request Jun 3, 2015
@rvagg rvagg mentioned this pull request Jun 11, 2015
@Trott Trott deleted the todo branch October 14, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants