src: fix deferred events not working with -e #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var result = module._compile(script, name + '-wrapper'); | ||
| if (process._print_eval) console.log(result); | ||
| // Defer evaluation for a tick. This is something of a workaround | ||
| // for deferrend events not firing when evaluating scripts from the |
There was a problem hiding this comment.
s/deferred/ ?
Also "something of" may be better understood as "somewhat of", at least to me.
|
The original / one of the original bug reporters already submitted a test case for this (#1581). Should we use theirs? |
|
Oh, I hadn't seen that. I don't think @rmg minds. |
Defer evaluation of the script for a tick. This is a workaround for events not firing when evaluating scripts on the command line with -e. Fixes: nodejs#1600 PR-URL: nodejs#1793 Reviewed-By: Trevor Norris <[email protected]>
The non-isolate version of node::FatalException() is deprecated, switch to the version that takes an isolate as its first argument. PR-URL: nodejs#1793 Reviewed-By: Trevor Norris <[email protected]>
Commit 3e1b1dd ("Remove excessive copyright/license boilerplate") left in a few lines of boilerplate here and there. This commit removes them. PR-URL: nodejs#1793 Reviewed-By: Trevor Norris <[email protected]>
The JS source files in test/addons/doc-*/ are scraped from the reference documentation in doc/api and need not conform to the style guide. PR-URL: nodejs#1793 Reviewed-By: Trevor Norris <[email protected]>
|
@bnoordhuis LGTM |
This was referenced May 27, 2015
andrewdeandrade
pushed a commit
to andrewdeandrade/node
that referenced
this pull request
Jun 3, 2015
Defer evaluation of the script for a tick. This is a workaround for events not firing when evaluating scripts on the command line with -e. Fixes: nodejs/node#1600 PR-URL: nodejs/node#1793 Reviewed-By: Trevor Norris <[email protected]>
andrewdeandrade
pushed a commit
to andrewdeandrade/node
that referenced
this pull request
Jun 3, 2015
The non-isolate version of node::FatalException() is deprecated, switch to the version that takes an isolate as its first argument. PR-URL: nodejs/node#1793 Reviewed-By: Trevor Norris <[email protected]>
andrewdeandrade
pushed a commit
to andrewdeandrade/node
that referenced
this pull request
Jun 3, 2015
Commit 3e1b1dd ("Remove excessive copyright/license boilerplate") left in a few lines of boilerplate here and there. This commit removes them. PR-URL: nodejs/node#1793 Reviewed-By: Trevor Norris <[email protected]>
andrewdeandrade
pushed a commit
to andrewdeandrade/node
that referenced
this pull request
Jun 3, 2015
The JS source files in test/addons/doc-*/ are scraped from the reference documentation in doc/api and need not conform to the style guide. PR-URL: nodejs/node#1793 Reviewed-By: Trevor Norris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R=@trevnorris
CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/710/
Sorry, it turned out a bit bigger than expected. I had to do some cleanup work to get
make testto pass.