-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update AUTHORS list #1776
doc: update AUTHORS list #1776
Conversation
@yosuke-furukawa note you are going in as your gmail address even though your git email has changed, which do you prefer (see .mailmap diff on this PR)? |
@rvagg Can you include my actual name as well? Maybe like |
@thefourtheye we don't really have a convention of including github handles here, it's mainly just a list of names @ email addresses that are pulled from your git config (i.e. the git log). Would you mind if I made it just |
Sam Mikes [email protected] Thanks! On Fri, May 22, 2015 at 7:22 PM, Rod Vagg [email protected]
|
the entries now come up as
See the .mailmap attached to this PR for what was done to make that happen. Will wait for feedback from @thefourtheye before proceeding. |
@raff Cool, that should be fine 😊 I ll update my |
LGTM |
@rvagg My email is [email protected] . |
Update AUTHORS list using tools/update-authors.sh PR-URL: nodejs#1776 Reviewed-By: Ben Noordhuis <[email protected]>
367ffd1 |
Update AUTHORS list using tools/update-authors.sh PR-URL: nodejs/node#1776 Reviewed-By: Ben Noordhuis <[email protected]>
Update AUTHORS list using tools/update-authors.sh
@smikes and @thefourtheye you are going in as:
Can I put in a proper name for either of you or is this preferred?