test: fix test-sync-io-option #1734
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Wait for all the data to be available in stderr before checking its contents.
In FreeBSD this was failing because stderr data was being emitted in multiple chunks.
- 4 WARNINGS are printed instead of 2 for each sync call inside readFileSync.
require('fs') does not print any trace.
|
This test was failing in FreeBSD: |
|
R=@trevnorris? |
|
CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/690/ Centos5-32 is jenkins failing to connect to github for who knows why. |
|
Gah! What an idiotic oversight on my part. Thanks for getting the fix so promptly. LGTM. |
|
This also just popped up in one of my OSX runs. |
brendanashworth
pushed a commit
that referenced
this pull request
May 20, 2015
Wait for all the data to be available in stderr before checking its
contents. In FreeBSD this was failing because stderr data was being
emitted in multiple chunks. 4 WARNINGS are printed instead of 2 for
each sync call inside readFileSync. require('fs') does not print any
trace.
PR-URL: #1734
Reviewed-By: Trevor Norris <[email protected]>
|
Thanks for the pull request! It has been landed in 8676319. |
andrewdeandrade
pushed a commit
to andrewdeandrade/node
that referenced
this pull request
Jun 3, 2015
Wait for all the data to be available in stderr before checking its
contents. In FreeBSD this was failing because stderr data was being
emitted in multiple chunks. 4 WARNINGS are printed instead of 2 for
each sync call inside readFileSync. require('fs') does not print any
trace.
PR-URL: nodejs/node#1734
Reviewed-By: Trevor Norris <[email protected]>
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In FreeBSD this was failing because stderr data was being emitted in multiple chunks.
require('fs') does not print any trace.