Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

isolate the module and docs #186

Closed
maddhruv opened this issue Dec 4, 2018 · 12 comments
Closed

isolate the module and docs #186

maddhruv opened this issue Dec 4, 2018 · 12 comments

Comments

@maddhruv
Copy link
Contributor

maddhruv commented Dec 4, 2018

The concern I want to raise here is about isolating the module/script that we use for collecting the node versions docs and the translated docs into two different branches

  • master branch - docs (en + translated)
  • module branch - module (i18n) and scripts

Why?

It is very difficult to clone/pull all these translated file/docs every time, which is an unnecessary flow if one wants to write some scripts/module

@maddhruv
Copy link
Contributor Author

maddhruv commented Dec 4, 2018

/cc @zeke @amorist @lukaszewczak

@amorist
Copy link
Contributor

amorist commented Dec 4, 2018

If we want to release the npm module or write script, may need docs content.

https://github.com/electron/i18n/blob/master/lib/apis.js

@maddhruv
Copy link
Contributor Author

maddhruv commented Dec 4, 2018

but even if we are to publish the module, will we be publishing all the content as well?

@amorist
Copy link
Contributor

amorist commented Dec 4, 2018

just json file

@amorist
Copy link
Contributor

amorist commented Dec 4, 2018

or load content from master branch (master branch - docs (en + translated))

@maddhruv
Copy link
Contributor Author

maddhruv commented Dec 4, 2018

the problem that shall persist is about cloning the whole repo with translated content every time?

@amorist
Copy link
Contributor

amorist commented Dec 4, 2018

@zeke
Copy link
Contributor

zeke commented Dec 4, 2018

It is very difficult to clone/pull all these translated file/docs every time

@maddhruv can you describe in more detail what is difficult about this process?

@maddhruv
Copy link
Contributor Author

maddhruv commented Dec 5, 2018

Whenever I clone or fetch the repo
There are thousands of files - translated docs
Which need to be fetched

@zeke
Copy link
Contributor

zeke commented Dec 5, 2018

Yes there are many files, but that is the nature of a project like this. I don't see how breaking things up into separate branches would solve the problem, as the code that builds the module will need to access all the content, and you can't be on two branches at once. They should live together.

The module content that gets published to npm, however, is a different story. The published npm module will need to be able to access the content in some structured format like JSON or LevelDB, but the original markdown files and the JavaScript code used to build the module can be omitted from the npm package using and .npmignore file.

@maddhruv
Copy link
Contributor Author

maddhruv commented Dec 6, 2018

can't we do both the things separate as

  • translated docs is a separate module
  • translate script/module is separate
    ?

@alexandrtovmach
Copy link
Contributor

alexandrtovmach commented Mar 27, 2020

It's not an issue anymore, because we're using Crowdin. Should be closed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants