Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Known issues in changelog. #88

Closed
stevemao opened this issue Feb 2, 2016 · 10 comments
Closed

Known issues in changelog. #88

stevemao opened this issue Feb 2, 2016 · 10 comments

Comments

@stevemao
Copy link

stevemao commented Feb 2, 2016

Some known issues are listed in changelog https://github.com/nodejs/node/blob/master/CHANGELOG.md#known-issues. But most of the confirmed bugs are not. Why?

@rvagg
Copy link
Member

rvagg commented Feb 3, 2016

to be honest, we don't have a solid policy on this, it's been mostly based on impact but the list has also been pretty static for a while with nobody paying attention to updating it

@nodejs/release my feeling on this is that if it's too hard to maintain the list from release to release then we should not even include it. I get the impression that cutting a release is hard enough without adding more tasks to the list so maybe we should trim it down to a simple link?

@cjihrig
Copy link

cjihrig commented Feb 3, 2016

I'd be in favor of dropping that section and just linking into the issue tracker.

@stevemao
Copy link
Author

stevemao commented Feb 3, 2016

Well it gives me a wrong impression. EG:

Are these recently introduced in the current release?
Does Node only has 4 or 5 bugs?
The bug "Surrogate pair in REPL can freeze terminal." is more important? or hard to fix so it appears in every new release?

@cjihrig
Copy link

cjihrig commented Feb 3, 2016

I can definitely see how this can be confusing. For the record, the surrogate pair REPL bug was first reported in the io.js 1.1.0 changelog.

Also, this has been brought up before in nodejs/node#1484.

@Fishrock123
Copy link

+1 to dropping it

@MylesBorins
Copy link

+1 to dropping as well. Alternatively we could introduce a new label from BIG BUGS and generate the list from that

@Fishrock123
Copy link

@thealphanerd the intention for "known issues" was to list issues effective a specific version. Issue labels can't really do that.

@MylesBorins
Copy link

Well a label for fixes not yet landed in particular version could be...

nodejs/node#4819 for example We are likely to do the security release before this fix is landed

@rvagg
Copy link
Member

rvagg commented Feb 9, 2016

Nobody left in favour of keeping "known issues" in its current form so it's being dropped from this week's releases, we can come up with a new approach in the future, perhaps linking to a dedicated label for "serious known issues". If we manage to actually properly use such a label we could even make changelog-maker spit out a list for our changelogs.

@stevemao
Copy link
Author

Closing as we are not including the section in changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants