Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 support in Node.js 12 #2363

Closed
adamjstewart opened this issue Dec 20, 2019 · 4 comments
Closed

Python 3 support in Node.js 12 #2363

adamjstewart opened this issue Dec 20, 2019 · 4 comments

Comments

@adamjstewart
Copy link

  • Node.js Version: 12.14.0
  • OS: macOS 10.15.2
  • Scope (install, code, runtime, meta, other?): install

Hi, I'm updating our package for node-js in the Spack package manager and was wondering if you could help. It looks like Node.js version 12 added experimental support for Python 3, and version 13 added full support, is that correct? How can I experiment with that Python 3 support? I tried setting PYTHON to my Python 3 executable, but it looks like the configure script still uses the system Python 2 instead.

I tried Node.js 13, but it seems that the libraries vendored with npm (specifically sharp) do not yet support Node.js 13.

@tgamblin

@adamjstewart
Copy link
Author

Looking at the Travis config files, do I need to set NODE_GYP_FORCE_PYTHON in addition to PYTHON?

@adamjstewart
Copy link
Author

Update: I got things working by running configure.py directly with the python3 executable instead of running the configure shell script.

@gireeshpunathil
Copy link
Member

thanks for self-diagnosing this!

maybe worthwhile to add a note to that effect in https://github.com/nodejs/node/blob/master/BUILDING.md#note-about-python-2-and-python-3 ? do you want to try a PR for that?

@richardlau
Copy link
Member

thanks for self-diagnosing this!

maybe worthwhile to add a note to that effect in https://github.com/nodejs/node/blob/master/BUILDING.md#note-about-python-2-and-python-3 ? do you want to try a PR for that?

Should be unnecessary for Node.js 13 and later because of nodejs/node#30091.

algitbot pushed a commit to alpinelinux/aports that referenced this issue May 26, 2020
So that python2 could be moved to community, see #11577

Following advice in nodejs/help#2363 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants