-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support same file name on windows #60
Comments
gengjiawen
added a commit
to gengjiawen/node
that referenced
this issue
Aug 23, 2020
targos
added a commit
to targos/gyp-next
that referenced
this issue
Sep 7, 2020
This change removes the duplicate basename checks for macOS and MSVS. The macOS one is no longer necessary and the solution generator for MSVS is updated to support duplicate names by reproducing the source directory structure in the intermediate directory. Closes: nodejs#60 BREAKING CHANGE: The `--no-duplicate-basename-check` option is removed.
targos
added a commit
to targos/gyp-next
that referenced
this issue
Sep 7, 2020
This change removes the duplicate basename checks for macOS and MSVS. The macOS one is no longer necessary and the solution generator for MSVS is updated to support duplicate names by reproducing the source directory structure in the intermediate directory. Closes: nodejs#60 BREAKING CHANGE: The `--no-duplicate-basename-check` option was removed.
targos
added a commit
to targos/gyp-next
that referenced
this issue
Sep 7, 2020
This change removes the duplicate basename checks for macOS and MSVS. The macOS one is no longer necessary and the solution generator for MSVS is updated to support duplicate names by reproducing the source directory structure in the intermediate directory. Closes: nodejs#60 BREAKING CHANGE: The `--no-duplicate-basename-check` option was removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Mainly to fix nodejs/node-v8#161 (comment)
In short: Windows .obj files generated in flattened directory causing linker errors
The text was updated successfully, but these errors were encountered: