Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add VCToolsVersion for msvs #209

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

tr-takatsuka
Copy link
Contributor

Add the ability to specify the 'MSVC toolset version' for the VisualStudio platform.

This PR created for gyp-next, following the adviced in node-gyp. Thank you.
nodejs/node-gyp#2910

Usage example for binding.gyp

'targets': [
 {
   'configurations': {
     'Debug': {
       "msvs_configuration_attributes": {
         "VCToolsVersion": "14.36.32532",

Thank you and best regards.

…> for the VisualStudio platform.

Usage example for binding.gyp

```
'targets': [
 {
   'configurations': {
     'Debug': {
       "msvs_configuration_attributes": {
         "VCToolsVersion": "14.36.32532",
```
@cclauss
Copy link
Contributor

cclauss commented Oct 11, 2023

@StefanStojanovic @rzhao271 Your reviews, please.

@StefanStojanovic
Copy link
Contributor

I see a problem with this PR, and all future PRs in this repo unrelated to changes directly. The Node.js Windows integration / build-windows workflow runs on windows-2019 which from what I know uses VS2019. However, after this landed in Node.js, it no longer supports building on VS2019 and requires VS2022. Luckily for us, fix should be as simple as changing the line I referenced in a workflow file to windows-2022 or even simpler to windows-latest. We could do this in another PR, land it and after that rebase this one, or directly in this PR. Although first approach would be cleaner I do not have any objections to doing it in here.

Copy link
Contributor

@rzhao271 rzhao271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

extract from comments by PR nodejs#209:add VCToolsVersion for msvs
```
The Node.js Windows integration / build-windows workflow runs on windows-2019 which from what I know uses VS2019.
However, after this landed in Node.js, it no longer supports building on VS2019 and requires VS2022.
Luckily for us, fix should be as simple as changing the line I referenced in a workflow file to windows-2022 or even simpler to windows-latest.
```
@tr-takatsuka
Copy link
Contributor Author

Thanks for the review.

I think I have understood your points correctly.
changed build-windows workflow to "windows-latest".
could you review if this change is correct?

@StefanStojanovic
Copy link
Contributor

Thank you @tr-takatsuka. Yes you understood me correctly. @cclauss in this repo I do not have a write access, so can you please approve changes to trigger the workflows?

@StefanStojanovic
Copy link
Contributor

Is there something more that should be done with this PR? I think it can land cc @cclauss

Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@cclauss cclauss merged commit 0e35ab8 into nodejs:main Oct 18, 2023
20 checks passed
@tr-takatsuka tr-takatsuka deleted the add_vctoolsversion branch October 19, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants