-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add VCToolsVersion for msvs #209
Conversation
…> for the VisualStudio platform. Usage example for binding.gyp ``` 'targets': [ { 'configurations': { 'Debug': { "msvs_configuration_attributes": { "VCToolsVersion": "14.36.32532", ```
@StefanStojanovic @rzhao271 Your reviews, please. |
I see a problem with this PR, and all future PRs in this repo unrelated to changes directly. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
extract from comments by PR nodejs#209:add VCToolsVersion for msvs ``` The Node.js Windows integration / build-windows workflow runs on windows-2019 which from what I know uses VS2019. However, after this landed in Node.js, it no longer supports building on VS2019 and requires VS2022. Luckily for us, fix should be as simple as changing the line I referenced in a workflow file to windows-2022 or even simpler to windows-latest. ```
Thanks for the review. I think I have understood your points correctly. |
Thank you @tr-takatsuka. Yes you understood me correctly. @cclauss in this repo I do not have a write access, so can you please approve changes to trigger the workflows? |
Is there something more that should be done with this PR? I think it can land cc @cclauss |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!!
Add the ability to specify the 'MSVC toolset version' for the VisualStudio platform.
This PR created for gyp-next, following the adviced in node-gyp. Thank you.
nodejs/node-gyp#2910
Usage example for binding.gyp
Thank you and best regards.