-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add command line argument for gyp --version
#164
Conversation
pylib/gyp/__init__.py
Outdated
|
||
options, build_files_arg = parser.parse_args(args) | ||
if options.version: | ||
print("v0.13.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be done reading https://github.com/nodejs/gyp-next/blob/main/setup.py ?
Currently auto release may not update this timely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version number should not be stored in an executable file like setup.py
but in a config file like pyproject.toml
or setup.cfg
. I will make that change...
Shrink |
gyp --version
gyp --version
Support will be difficult without this basic diagnostic capability.
DRY says we should not support the version number both in this file and
setup.py