Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot comments three times on V8 CI #355

Open
targos opened this issue Oct 25, 2022 · 4 comments
Open

Bot comments three times on V8 CI #355

targos opened this issue Oct 25, 2022 · 4 comments

Comments

@targos
Copy link
Member

targos commented Oct 25, 2022

Example: nodejs/node#45162 (comment)

Can we make it comment on the top-level job instead of the three subjobs?

@targos
Copy link
Member Author

targos commented Oct 25, 2022

/cc @gengjiawen

@gengjiawen
Copy link
Member

This is introduced in #353, not sure the best way to fix it.

@joyeecheung
Copy link
Member

It seems the bot only got three events for each of the subjobs, so there isn't an event for the parent job. Either we reconfigure Jenkins so that it triggers subjobs as real subjobs (instead of the same job but with different configuration?), or the bot needs to know how to merge the CI links.

@gengjiawen
Copy link
Member

Either we reconfigure Jenkins so that it triggers subjobs as real subjobs (instead of the same job but with different configuration?)

I am for this one, as long as we can keep the same url and config.
Context: nodejs/node-core-utils@046bc0d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants