Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lts-watch-* labels should not be applied when dont-land-on-* exist #112

Open
mscdex opened this issue Dec 29, 2016 · 4 comments
Open

lts-watch-* labels should not be applied when dont-land-on-* exist #112

mscdex opened this issue Dec 29, 2016 · 4 comments

Comments

@mscdex
Copy link
Contributor

mscdex commented Dec 29, 2016

As the title says, if for example a PR has the 'dont-land-on-v6.x' label already, then the bot should not try to add an 'lts-watch-v6.x' label.

@Fishrock123
Copy link
Contributor

@mscdex do you have an example of this happening? I think in most cases it will not land cleanly then.

@mscdex
Copy link
Contributor Author

mscdex commented Jan 4, 2017

@Fishrock123 Example: nodejs/node#10445

node v6.x and older do not have a fast function.bind(), so that PR should not be backported.

@gibfahn
Copy link
Member

gibfahn commented Jan 29, 2017

Bump, happened in nodejs/node#10839 (comment)

image

@mscdex
Copy link
Contributor Author

mscdex commented Jan 29, 2017

@gibfahn It might be a good idea to merge these discussions on backport-related issues into the newly created issue here: #120 so that we can compile a list of issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants