-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attempt-backport should ignore semver-major changes #105
Comments
Should be fairly easy to do, but a lot will slip by because they will be labeled by us later so I'm not 100% sure what to do about that. Have any ideas? |
Yes but at least once the PR is marked semver-major, the bot will stop trying on every push. |
Maybe remove any previous backporting labels when GitHub emits a labelling event for semver-major being added? |
@thealphanerd Think it might work better if we only added these labels once a PR is closed/merged? |
That does mean that people won't know if they'll need to adjust it until after though... :/ So IMO would be worse. |
I'm ok with this. As long as it is accurate. edit: still better than nothing |
So does everyone agree that the bot should (at least) not add any backport-related labels if it sees a change in commits and a I'm not sure proactively removing existing backport-related labels would be a good thing, especially if someone intentionally added the label. |
Title says it all, github-bot should not attempt to backport changes marked as semver-major.
/cc @Fishrock123
The text was updated successfully, but these errors were encountered: