From 0ee821a45493a4411ac947a6e53a02f871a99b8b Mon Sep 17 00:00:00 2001 From: Brian White Date: Sun, 14 May 2017 14:22:52 -0400 Subject: [PATCH] labels: add 'build' for android-configure (#144) --- lib/node-labels.js | 2 +- test/unit/node-labels.test.js | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/lib/node-labels.js b/lib/node-labels.js index 4918fe4b..3862ca6f 100644 --- a/lib/node-labels.js +++ b/lib/node-labels.js @@ -49,7 +49,7 @@ const subSystemLabelsMap = new Map([ [/^(tools\/)?(Makefile|BSDmakefile|create_android_makefiles)$/, 'build'], [/^tools\/(install\.py|genv8constants\.py|getnodeversion\.py|js2c\.py|utils\.py|configure\.d\/.*)$/, 'build'], [/^vcbuild\.bat$/, ['build', 'windows']], - [/^configure|node\.gyp|common\.gypi$/, 'build'], + [/^(android-)?configure|node\.gyp|common\.gypi$/, 'build'], // more specific tools [/^tools\/gyp/, ['tools', 'build']], [/^tools\/doc\//, ['tools', 'doc']], diff --git a/test/unit/node-labels.test.js b/test/unit/node-labels.test.js index c5712508..302ff246 100644 --- a/test/unit/node-labels.test.js +++ b/test/unit/node-labels.test.js @@ -568,3 +568,14 @@ for (const info of specificTools) { }) } }) + +tap.test('label: "build" when ./android-configure has been changed', (t) => { + const labels = nodeLabels.resolveLabels([ + 'android-configure' + ]) + + t.same(labels, ['build']) + + t.end() +}) +