-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Node.js 18.0.0 #1697
feat: Node.js 18.0.0 #1697
Conversation
@nodejs/docker I'm not sure why Stretch is failing, but since it's EOL in June, should it just be dropped? |
Ah, looks like it's related to GLIBC 2.28 being needed
I'm leaning towards just dropping stretch for this new release line (since we'll be removing it when it hits EOL in a month anyway) |
Those issues with stretch are likely caused/mentioned by nodejs/node#42351. |
ENV NODE_VERSION 18.0.0 | ||
|
||
RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ | ||
&& case "${dpkgArch##*-}" in \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a particular reason why the indentation in the full debian Docker files differs from that in the slim editions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not particularly, it's just coming from the template file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditching stretch
seems reasonable.
docker-library/official-images#12158
We recommend that maintainers plan to remove any Stretch-based images on or before 2022-06-30.
Created PR on the official-images repo (docker-library/official-images#12266). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub. |
D'oh, forgot to fudge the dates in version.json or properly fix it, since stackbrew.js is creating duplicate tags for the overlapping date ranges |
@nschonni can you fix it? |
Fixes #1696
Description
Motivation and Context
Testing Details
Example Output(if appropriate)
Types of changes
Checklist