Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm install --production #11

Closed
wants to merge 3 commits into from
Closed

Conversation

refractalize
Copy link

Was there a reason not to use npm install --production in the onbuild Dockerfiles?

I found my docker build downloading all my dev dependencies and wondered...

Cheers

@md5
Copy link

md5 commented Feb 12, 2015

See #3 for previous discussion

@md5
Copy link

md5 commented Feb 12, 2015

Also, docker-library/node#14

@eexit
Copy link

eexit commented Nov 4, 2015

I don't agree with that: if you need production dependencies, just add the NODE_ENV=production env variable. In my use case, I build the container into the CI and only the succeed container will go into production, we use the same container to ensure the reliability of the deployed code.

@Starefossen
Copy link
Member

I am closing this since we want the onbuild variant to be as general purpose as possible and there exists ways to force production packages only gets installed.

@chorrell
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants