Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node:12.13/14-slim ships with unsupported OpenSSL? #1181

Closed
IdanAdar opened this issue Jan 4, 2020 · 7 comments · Fixed by #1182
Closed

node:12.13/14-slim ships with unsupported OpenSSL? #1181

IdanAdar opened this issue Jan 4, 2020 · 7 comments · Fixed by #1182

Comments

@IdanAdar
Copy link

IdanAdar commented Jan 4, 2020

See in https://www.openssl.org/policies/releasestrat.html

Version 1.1.1 will be supported until 2023-09-11 (LTS).
Version 1.1.0 will be supported until 2019-09-11.

In the latest node:12.13-slim, openssl version returns OpenSSL 1.1.0l 10 Sep 2019

@IdanAdar IdanAdar changed the title node:12.13-slim ships with unsupported OpenSSL? node:12.13/14-slim ships with unsupported OpenSSL? Jan 4, 2020
@IdanAdar
Copy link
Author

IdanAdar commented Jan 7, 2020

@SimenB In reading through the comments of your PR it seems that you're basically dropping OpenSSL completely from the base image, which means I guess that I should install it myself, but I tried this and it still installed that same old OpenSSL version, so how is this helping to resolve the issue? How do I then install the latest OpenSSL version?

@SimenB
Copy link
Member

SimenB commented Jan 7, 2020

I don't know if it's been released for stretch? You could use buster, which is debian 10 instead of debian 9.

This will solve it in that we will no longer ship an image with openssl installed. How to install a given version of openssl into debian:stretch-slim is a separate issue. A quick google seems to indicate it cannot be done out of the box: https://www.reddit.com/r/debian/comments/b3rbf2/openssl_111_tls_13_under_debian_stretch/

@IdanAdar
Copy link
Author

IdanAdar commented Jan 8, 2020

Well, we're using node:12.13-slim, that one is using debian 9 no? Not much I can do about that... unless someone updates slim to use debian 10.

@SimenB
Copy link
Member

SimenB commented Jan 8, 2020

We have buster images, docker run node:12.13-buster-slim

@IdanAdar
Copy link
Author

IdanAdar commented Jan 8, 2020

So with node:12.13-buster-slim as-is today apt-get install openssl should provide OpenSSL 1.1.1d?

@SimenB
Copy link
Member

SimenB commented Jan 8, 2020

You might need apt-get update first but otherwise yeah

@brandonw
Copy link

Removing the package causes any new images that are based off of these images to no longer have a default config, which implicitly reduces the SECLEVEL for all openssl usage on that image.

It may be useful to notify consumers of this image that they should configure a reasonable openssl.cnf in the Best Practices section of the README.

I can't find any release notes for these images, but if they exist, an amended release note that if you use openssl, an openssl.cnf must now be configured in each image instead of inheriting the package openssl.cnf would also be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants