Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-evaluate --trace-gc in the tools tier-list #554

Closed
tony-go opened this issue Apr 6, 2022 · 5 comments
Closed

Re-evaluate --trace-gc in the tools tier-list #554

tony-go opened this issue Apr 6, 2022 · 5 comments
Assignees

Comments

@tony-go
Copy link
Member

tony-go commented Apr 6, 2022

Hi, Diag family 👋

As mentioned in issue #532, I proposed to add --trace-gc to the tier list. Here is the pull request. You'll find there the discussion we had with @gireeshpunathil and the final statement we had here.

Then another PR was raised to add integration tests between Node.Js and --trace-gc (v8).

IMO, the remaining pillar is the documentation. We already have an API reference documentation. Maybe should we consider creating a guide?

As a Node.Js newcomer, I'd like to see a guide about: "how diagnosis a memory leak" and --trace-gc could be a protagonist there. Feel free to share any thoughts you have on this ^^ I'll probably raise a draft PR in the following days to expose the tree structure of this guide.

With love ❤️

@tony-go
Copy link
Member Author

tony-go commented Apr 19, 2022

I started working on a guide a few days ago but nothing strong enough to share it on a PR.

https://www.twitch.tv/videos/1459580297

@tony-go
Copy link
Member Author

tony-go commented Jun 28, 2022

Todo(@tony-go): Merge it into the current diagnostic memory doc.

@github-actions
Copy link

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Sep 27, 2022
@RafaelGSS
Copy link
Member

@tony-go it was added?

@github-actions github-actions bot removed the stale label Sep 28, 2022
@tony-go
Copy link
Member Author

tony-go commented Sep 28, 2022

yes

@tony-go tony-go closed this as completed Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants