Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostics WG Summit - Feb 12-13, 2018 - Ottawa, ON Canada #121

Closed
mike-kaufman opened this issue Nov 15, 2017 · 110 comments
Closed

Diagnostics WG Summit - Feb 12-13, 2018 - Ottawa, ON Canada #121

mike-kaufman opened this issue Nov 15, 2017 · 110 comments
Assignees

Comments

@mike-kaufman
Copy link
Contributor

mike-kaufman commented Nov 15, 2017

Diagnostics WG Summit

Proposed Agenda

Day 1 - Feb 12 2017

Key Themes - Part1
8:30 - 9:00 - Arrive and settle in
9:00 - 9:10 - Introductions
9:10 - 9:20 - End user perspectives (Netflix)
9:20 - 9:30 - Agenda review
9:30 - 10:00 - Post Mortem - priorities/issues

10:00 - 10:30 - break

Key Themes - Part 2
10:30 - 11:00 - Monitoring - priorities/issues
11:00 - 11:15 - Debugging - priorities/issues
11:15 - 11:30 - Platform neutrality/APIs
11:30 - 12:00 - Testing and Documenation

12:00 - 1:00 - Lunch

1:00 - 3:00 - Breakout 1
3:00 - 3:30 - Break
3:30 - 5:30 - Breakout 2
5:30 - 6:00 - Demo from James/Matteo

6:30 - Dinner

Day 2 - Feb 13 2017
9:00 - 11:00 - Breakout 3
11:00 - 1:00 - Breakout 4

1:00 - 2:00 - lunch

2:00 - 3:15 - Breakout review
3:15 - 3:30 - Break
3:30 - 5:00 - Breakout review continued, recap and actions

The agenda is structured as a review of the key themes related to Diagnostics in order
lay the context for for the more in depth breakout sections, the breakout sessions
themselves and then finally a review of the output from the breakout sections and creation of
an action plan going forward.

Attendees:

  1. @mhdawson
  2. @mcollina
  3. @mike-kaufman
  4. @Qard
  5. @hashseed
  6. @watson
  7. @mrkmarron
  8. @jasnell
  9. @danielkhan
  10. @komawar
  11. @joyeecheung
  12. @cjihrig
  13. @fhinkel
  14. @jkrems
  15. @ofrobots
  16. @dshaw
  17. @kjin
  18. @aruneshchandra
  19. @hekike
  20. @mmarchini
  21. @Flarna
  22. @Hollerberg
  23. @distracteddev
  24. @apapirovski
  25. @skaegi
  26. @Fishrock123

Doc to refine subtopics/discussion points:
https://docs.google.com/document/d/1mB3nrCOhgKPEpPebpUEBDZQse6yKX4vwuwj-RpAWXWI/edit?usp=sharing

@mhdawson
Copy link
Member

Will look into how to book a Room in our office in Ottawa and then suggest a date/time

@watson
Copy link
Member

watson commented Nov 18, 2017

I'm in California for work from the Feb 26th to Mar 6th

@danielkhan
Copy link
Contributor

Thank you for setting that up. I'll definitely attend if it's not in the last week of January. We should also ping @nodejs/post-mortem because if we merge, the summit would be a great kick off for that.

@mhdawson
Copy link
Member

mhdawson commented Nov 21, 2017

To start the discussion.

@nodejs/diagnostics
@nodejs/post-mortem
@nodejs/tsc

I would suggest we hold the summit on Mon Feb 12 and Tue Feb 13 in Ottawa at the IBM office. The weekends before/after include Winderlude if you like skating and the IBM office is close the airport if you want to just fly in/out. Please comment as to wether you want to participate and if those those days work for you or not and we'll either confirm or iterate as necessary.

I would suggest we structure discussion in terms of themes as we did at the first vm summit.

The themes I'd have in mind (probably incomplete, please make additional suggestions) would be:

  • Post mortem diagnosis

    • Core tooling that should be part of Node.js itself
      • heapdump generation
      • node report generation (light weight easy to consume dump)
      • core dump generation
    • Core dump introspection
      • llnode, mdb, etc.
      • javascripts APIs
      • maintenance/automation of keeping required data up to date
    • Supporting Promises/async functions
    • What is missing ?
  • Monitoring

    • Asynchronous context tracking
      • Async Hooks
    • Tracing
      • Adding Node.js trace points
      • Flight recorder
    • Loader Hooks ?
    • Profiling
    • What else should Node.js have in order to support great monitoring
  • Debugging

    • Not sure what we need to discuss on this front....
  • Documentation/Guidance

    • Module developers guide (as discussed in VM summit in Germany)
    • How to investigate common issues
  • Testing

    • We don't necessarily have good testing or visibility into the testing we do have
    • Diagnostics test pass/fail should be a release criteria ?
  • Platform neutrality/APIs

    • Expanding N-API to cover diagnostics APIs ?
    • Platform neutral internal APIs
  • What's missing

    • How does Node.js stack up against other languages in terms of diagnostics
    • Would be good to be able to capture what we have, what we need to work on and have deck to
      position that Node.js is good from a diagnostics point of view (possibly after some work)

We can structure however we want but at the first vm summit we had the following general approach

  • Morning of first day, discuss key themes as a group. At the end of the morning identify groups that
    want to break out to discuss specific themes
  • Afternoon of first day/Morning of second day groups meet to discuss specific themes, make concrete
    plans for next steps and start working on those steps.
  • Afternoon of second day get back together as a full group and each sub-group presents an overview of
    what they discussed/planned/completed.

Depending on the number of people we get and the interest in the themes it may or may not make sense to break out into sub-groups.

@jasnell
Copy link
Member

jasnell commented Nov 21, 2017

Definitely +1, glad to see this move forward. I'll definitely be there.

@jasnell
Copy link
Member

jasnell commented Nov 21, 2017

I will say that Feb 13th is not a great day as I would need to leave early in order to not be traveling on Feb 14th... which is problematic from a My-Wife-Will-Kill-Me-If-I'm-Gone-On-Valentines-Day perspective. That said, Feb 8-9 and Feb 19-23 are out for me also.

@dshaw
Copy link

dshaw commented Nov 21, 2017

+1

1 similar comment
@danielkhan
Copy link
Contributor

+1

@benjamingr
Copy link
Member

Would be amazing to see a push for a better postmortem story for async functions.

@mhdawson
Copy link
Member

@benjamingr I knew I was forgetting something. I had thought of that at one point but missed it when putting together the overview.

@mhdawson
Copy link
Member

@benjamingr added

Supporting Promises/async functions

under the post mortem section. If that's not what you had in mind just give me some text to add

@ofrobots
Copy link
Contributor

I'm tentative. I have other travel planned for the second half of Feb. I will be able to confirm closer to the date.

@jkrems
Copy link
Contributor

jkrems commented Nov 22, 2017

I'll be there and I'm pretty flexible about the dates.

@benjamingr
Copy link
Member

@mhdawson that's exactly what I meant, thank you for including and considering it.

@komawar
Copy link

komawar commented Nov 22, 2017

I would like to attend, prefer Feb.

@hashseed
Copy link
Member

I would like to attend as well.

@watson
Copy link
Member

watson commented Nov 24, 2017

Those dates sounds fine with me 👍

@mhdawson
Copy link
Member

@bmeurer FYI in case you have not seen this yet.

@bmeurer
Copy link
Member

bmeurer commented Nov 24, 2017

I have seen this already, yes. Chatted with @hashseed today and we decided it makes a lot of sense for him to go, since he knows the relevant parts of V8 a lot better than I do. 👍

@watson
Copy link
Member

watson commented Nov 24, 2017

How soon can we settle on dates? I'd prefer to buy plane tickets and book hotel before it gets too expensive 😃

@mhdawson
Copy link
Member

@watson, would a target of agreeing by mid-to-end next week work ?

So far it sounds like my proposed dates are ok but was thinking we should give it a few more days given the Thanksgiving weekend in the US.

@watson
Copy link
Member

watson commented Nov 24, 2017

Absolutely, no problem 😃

@kjin
Copy link
Contributor

kjin commented Nov 28, 2017

+1, mid-February would be great.

@fhinkel
Copy link
Member

fhinkel commented Dec 4, 2017

I'll probably be joining, too. Are the dates set yet?

@cjihrig
Copy link

cjihrig commented Dec 4, 2017

These dates work for me.

@mhdawson
Copy link
Member

mhdawson commented Dec 4, 2017

We are pretty much set on Mon Feb 12 and Tue Feb 13. I have a room booked that should hold 20. I just want to take a look at it tomorrow when I'm in the office and then I will comment here confirming.

@skaegi
Copy link

skaegi commented Feb 7, 2018

@mhdawson Although not a member of the WG I'm in Ottawa and would also like to attend. I'm currently part of TC39 (though less involved now) and can offer some perspective having both written a JavaScript debugger and participated in earlier efforts to standardize a JavaScript Debug Protocol.

@mhdawson
Copy link
Member

mhdawson commented Feb 7, 2018

@skaegi added. Looking forward to seeing you there.

@mhdawson
Copy link
Member

mhdawson commented Feb 7, 2018

@mhdawson
@mcollina
@mike-kaufman
@Qard
@hashseed
@watson
@mrkmarron
@jasnell
@danielkhan
@komawar
@joyeecheung
@cjihrig
@fhinkel
@jkrems
@ofrobots
@dshaw
@kjin
@aruneshchandra
@hekike
@mmarchini
@Flarna
@Hollerberg
@distracteddev
@apapirovski
@skaegi

I've made a reservation for Monday at 6:30 at a pub that is a short walk down the street from the office. They tell me the menu is typical pub food and there are a few vegetarian options. I've assumed most people will want to come along but they would like a good estimate of the number of people so can each of you use the thumbs up/down to confirm if you will be coming. I only have the budget for lunch so we'll each be on our own to cover the cost of dinner.

@Fishrock123
Copy link
Contributor

Heya - there was a bit of a planning snafu but it looks like I’ll be making my way up, one way or other.

@mhdawson could you add me to that? Thanks!

@mhdawson
Copy link
Member

mhdawson commented Feb 9, 2018

@Fishrock123 added.

@apapirovski
Copy link
Member

@mhdawson Unfortunately I have to cancel at the last minute. A few of my move-related appointments ended up falling on Tuesday and I can't reschedule. 😞

@watson
Copy link
Member

watson commented Feb 11, 2018

Unfortunately Air Canada have canceled my flight due to snow in Ottawa. They have put me on a flight tomorrow instead, but it doesn’t land in Ottawa until 9:52am. I’ll just take a taxi directly to the office, so hopefully I’ll be there before 11 depending on how difficult immigration is

@Fishrock123
Copy link
Contributor

Is anyone else staying in the Hilton Garden Inn and want to meet up tonight?

@Qard
Copy link
Member

Qard commented Feb 11, 2018

I'm downtown at the Marriott. I'm happy to meet anyone downtown though.

@mhdawson
Copy link
Member

@apapirovski, sorry to hear to you can't make it.

@mhdawson
Copy link
Member

@watson, sorry to hear that. The weather has been a bit fun today with freezing rain, we'll be lucky if you are the only.

@mhdawson
Copy link
Member

@mhdawson
Copy link
Member

@mhdawson mhdawson reopened this Feb 12, 2018
@mmarchini
Copy link
Contributor

Thecore to heap dump tool I've been working on:
https://github.com/mmarchini/llnode/tree/core-to-snapshot

Also, a quick video demonstrating how it works:
https://www.youtube.com/watch?v=ou4i5vw70eg

@mhdawson
Copy link
Member

Will post new meeting link once we start up again after lunch.

@komawar
Copy link

komawar commented Feb 12, 2018

@mhdawson do you guys have a link for the next part of hangout?

@mhdawson
Copy link
Member

@mhdawson
Copy link
Member

p_20180212_110507_vhdr_on 1

@hekike
Copy link
Contributor

hekike commented Feb 12, 2018

@yunong's CPU Profiling Roadmap: #148

@mhdawson
Copy link
Member

p_20180212_134720_vhdr_on 1

p_20180212_134717_vhdr_on 1

p_20180212_121140_vhdr_on 1

p_20180212_121139_vhdr_on 1

p_20180212_113742_vhdr_on 1

p_20180212_113737_vhdr_on 1
p_20180212_110507_vhdr_on 1
p_20180212_121136_vhdr_on 1

@mmarchini
Copy link
Contributor

mmarchini commented Feb 13, 2018

@mcollina can you share the photos from the first Breakout, with the use cases and dream tools?

@mhdawson
Copy link
Member

@mcollina
Copy link
Member

use cases
my app is slow
unexpected memory usage

@mike-kaufman
Copy link
Contributor Author

Monkey Patching Discussion live-stream: http://youtu.be/W2rVLXr9WFU

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests