Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should parse-github-url be added to citgm? #933

Open
Trott opened this issue Nov 22, 2022 · 2 comments
Open

Should parse-github-url be added to citgm? #933

Trott opened this issue Nov 22, 2022 · 2 comments

Comments

@Trott
Copy link
Member

Trott commented Nov 22, 2022

    Should parse-github-url be added to citgm?

Originally posted by @ljharb in nodejs/node#45526 (comment)

@Trott
Copy link
Member Author

Trott commented Nov 22, 2022

On the one hand, 1 million+ weekly downloads says "yes".

On the other hand, no commits or releases in 5 years suggests "maybe not" because it suggests that we might not be able to get the maintainers to patch it for breaking changes in Node.js anyway.

@nodejs/citgm Thoughts? Do we have a requirement that someone sign on to be the maintainer that we contact when we find problems or anything like that?

@ljharb
Copy link
Member

ljharb commented Nov 22, 2022

It still seems useful to signal when a release is going to break it, even if it wouldn’t be updated.

Separately, though, the author remains active elsewhere, so i don’t think it’d be hard to get in touch with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants