From a8fee4125a37bd11b39c95560e9fe8fd02afbd63 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Tue, 2 Jun 2020 12:18:35 +0200 Subject: [PATCH 1/2] doc,win: drop support for VS2017 to build Node.js core --- ...windows-visualstudio-supported-versions.md | 28 +++++++++++-------- jenkins/scripts/VersionSelectorScript.groovy | 2 +- 2 files changed, 18 insertions(+), 12 deletions(-) diff --git a/doc/windows-visualstudio-supported-versions.md b/doc/windows-visualstudio-supported-versions.md index ba6c45c85..680449c4a 100644 --- a/doc/windows-visualstudio-supported-versions.md +++ b/doc/windows-visualstudio-supported-versions.md @@ -14,6 +14,7 @@ Supported versions for running the Node.js installer and executable as released. | v12 | 7 / 2008 R2 | | v13 | 7 / 2008 R2 | | v14 | 8.1 / 2012 R2 | +| v15 | 8.1 / 2012 R2 | ## For building Node.js Core @@ -21,10 +22,11 @@ Supported versions for building Node.js from source. | Node.js Version | Visual Studio Version | |-----------------|-------------------------------------| -| v10 | 2017 [5] | -| v12 | 2017, 2019 (flag) [8] | -| v13 | 2017, 2019 [9] | +| v10 | 2017 [1] | +| v12 | 2017, 2019 (flag) [2] | +| v13 | 2017, 2019 [3] | | v14 | 2017, 2019 | +| v15 | 2019 [5] | ## For building Node.js Addons @@ -33,9 +35,10 @@ Supported versions for building Node.js addons. End-users should have one of the | Node.js Version | Visual Studio Version | |-----------------|-------------------------------------------| | v10 | 2015, VCBT2015, 2017 | -| v12 | 2015, VCBT2015, 2017, 2019 [10] | +| v12 | 2015, VCBT2015, 2017, 2019 [4] | | v13 | 2015, VCBT2015, 2017, 2019 | | v14 | 2015, VCBT2015, 2017, 2019 | +| v15 | 2015, VCBT2015, 2017, 2019 | ## Official Releases @@ -43,20 +46,23 @@ These versions are used to build the official releases. | Node.js Version | Windows Version | Visual Studio Version | |-----------------|-----------------|-----------------------| -| v10 | 2012 R2 | 2017 [5] | +| v10 | 2012 R2 | 2017 [1] | | v12 | 2012 R2 | 2017 | | v13 | 2012 R2 | 2017 | | v14 | 2012 R2 | 2019 | +| v15 | 2012 R2 | 2019 | ## References -5. Support for Visual Studio 2015 was removed in v10.0.0. +1. Support for Visual Studio 2015 was removed in v10.0.0. - Pull Request: https://github.com/nodejs/node/pull/16868 - Pull Request: https://github.com/nodejs/node/pull/16969 -8. Support for Visual Studio 2019 was added behind a flag in v12.8.0. +2. Support for Visual Studio 2019 was added behind a flag in v12.8.0. - Pull Request: https://github.com/nodejs/node/pull/28781 -9. Support for Visual Studio 2019 by default was added in v13.0.1. +3. Support for Visual Studio 2019 by default was added in v13.0.1. - Pull Request: https://github.com/nodejs/node/pull/30022 -10. Support for **building addons** with Visual Studio 2019 was added in v12.8.0 (node-gyp 5.0.0). - - Pull Request: https://github.com/nodejs/node-gyp/pull/1762 - - Pull Request: https://github.com/nodejs/node/pull/28853 +4. Support for **building addons** with Visual Studio 2019 was added in v12.8.0 (node-gyp 5.0.0). + - Pull Request: https://github.com/nodejs/node-gyp/pull/1762 + - Pull Request: https://github.com/nodejs/node/pull/28853 +5. Support for Visual Studio 2017 was removed in v15.0.0. + - Pull Request: https://github.com/nodejs/node/pull/33694 diff --git a/jenkins/scripts/VersionSelectorScript.groovy b/jenkins/scripts/VersionSelectorScript.groovy index 08766c36a..a11c4f5d8 100644 --- a/jenkins/scripts/VersionSelectorScript.groovy +++ b/jenkins/scripts/VersionSelectorScript.groovy @@ -62,7 +62,7 @@ def buildExclusions = [ [ /vs2013(-\w+)?$/, testType, gte(6) ], [ /vs2015(-\w+)?$/, testType, gte(10) ], [ /vcbt2015(-\w+)?$/, testType, gte(10) ], - [ /vs2017(-\w+)?$/, testType, lt(8) ], + [ /vs2017(-\w+)?$/, testType, ltGte(8, 15) ], [ /vs2019(-\w+)?$/, testType, lt(13) ], [ /vs2015-x86$/, testType, gte(10) ], // compile x86 only once [ /vs2017-x86$/, testType, ltGte(10, 14) ], From 3ab64943ecae6cb4da4d37858010d9e7ba4b918a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Tue, 2 Jun 2020 12:20:34 +0200 Subject: [PATCH 2/2] doc: remove information on EOL Node.js 13.x --- doc/windows-visualstudio-supported-versions.md | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/doc/windows-visualstudio-supported-versions.md b/doc/windows-visualstudio-supported-versions.md index 680449c4a..f6071fd46 100644 --- a/doc/windows-visualstudio-supported-versions.md +++ b/doc/windows-visualstudio-supported-versions.md @@ -12,7 +12,6 @@ Supported versions for running the Node.js installer and executable as released. |-----------------|----------------------------| | v10 | 7 / 2008 R2 | | v12 | 7 / 2008 R2 | -| v13 | 7 / 2008 R2 | | v14 | 8.1 / 2012 R2 | | v15 | 8.1 / 2012 R2 | @@ -24,9 +23,8 @@ Supported versions for building Node.js from source. |-----------------|-------------------------------------| | v10 | 2017 [1] | | v12 | 2017, 2019 (flag) [2] | -| v13 | 2017, 2019 [3] | | v14 | 2017, 2019 | -| v15 | 2019 [5] | +| v15 | 2019 [4] | ## For building Node.js Addons @@ -35,8 +33,7 @@ Supported versions for building Node.js addons. End-users should have one of the | Node.js Version | Visual Studio Version | |-----------------|-------------------------------------------| | v10 | 2015, VCBT2015, 2017 | -| v12 | 2015, VCBT2015, 2017, 2019 [4] | -| v13 | 2015, VCBT2015, 2017, 2019 | +| v12 | 2015, VCBT2015, 2017, 2019 [3] | | v14 | 2015, VCBT2015, 2017, 2019 | | v15 | 2015, VCBT2015, 2017, 2019 | @@ -48,7 +45,6 @@ These versions are used to build the official releases. |-----------------|-----------------|-----------------------| | v10 | 2012 R2 | 2017 [1] | | v12 | 2012 R2 | 2017 | -| v13 | 2012 R2 | 2017 | | v14 | 2012 R2 | 2019 | | v15 | 2012 R2 | 2019 | @@ -59,10 +55,8 @@ These versions are used to build the official releases. - Pull Request: https://github.com/nodejs/node/pull/16969 2. Support for Visual Studio 2019 was added behind a flag in v12.8.0. - Pull Request: https://github.com/nodejs/node/pull/28781 -3. Support for Visual Studio 2019 by default was added in v13.0.1. - - Pull Request: https://github.com/nodejs/node/pull/30022 -4. Support for **building addons** with Visual Studio 2019 was added in v12.8.0 (node-gyp 5.0.0). +3. Support for **building addons** with Visual Studio 2019 was added in v12.8.0 (node-gyp 5.0.0). - Pull Request: https://github.com/nodejs/node-gyp/pull/1762 - Pull Request: https://github.com/nodejs/node/pull/28853 -5. Support for Visual Studio 2017 was removed in v15.0.0. +4. Support for Visual Studio 2017 was removed in v15.0.0. - Pull Request: https://github.com/nodejs/node/pull/33694