Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop VS2017 and remove EoL v13.x #2334

Merged
merged 2 commits into from
Jun 8, 2020
Merged

Drop VS2017 and remove EoL v13.x #2334

merged 2 commits into from
Jun 8, 2020

Conversation

targos
Copy link
Member

@targos targos commented Jun 2, 2020

No description provided.

@targos targos mentioned this pull request Jun 2, 2020
Closed
richardlau
richardlau approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would like sign off from @joaocgreis.

doc/windows-visualstudio-supported-versions.md Outdated Show resolved Hide resolved
@targos
Copy link
Member Author

targos commented Jun 8, 2020

@nodejs/build please merge to unblock nodejs/node#33694 :)

@AshCripps AshCripps merged commit 778d77f into nodejs:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@AshCripps AshCripps AshCripps approved these changes

@joaocgreis joaocgreis joaocgreis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@targos @joaocgreis @richardlau @AshCripps