Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand download validation to validate existing of all platforms #940

Closed
mhdawson opened this issue Oct 24, 2017 · 3 comments
Closed

Expand download validation to validate existing of all platforms #940

mhdawson opened this issue Oct 24, 2017 · 3 comments

Comments

@mhdawson
Copy link
Member

We seem to fairly regularly get reports like this one (often on ARM)

nodejs/node-v8#19 (comment)

We have a download validation job, but it currently does not fail if a platform is missing.

May be useful to add validation that downloads for all platforms exist.

@gdams since you did most of the work in the download validation script.

@refack
Copy link
Contributor

refack commented Oct 24, 2017

AFAICT checking nightlies (and canary nightlies) at least, is blocked by #908

@targos
Copy link
Member

targos commented Oct 26, 2017

For canary nightlies, I don't think we should block the download if a platform is missing.

@Trott
Copy link
Member

Trott commented Mar 22, 2019

Closing due to long period of inactivity. Feel free to re-open if this is a thing. I'm just trying to close stuff that has been ignored for sufficiently long that it seems likely it's not something we're going to get to.

@Trott Trott closed this as completed Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants