-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove openssl 1.1.1 buildbots #3496
Comments
Some distros still use 1.1.1 so keeping this going and being able to have advance notice would be great. A halfway approach might be to allow disabling any test that fails on 1.1.1 if its not obvious how to fix with the assumption that those who care about 1.1.1 would then later investigate and re-enable. |
@mhdawson nodejs/node#49712 is a PR which has an issue specific to OpenSSL 1.1.1. |
@richardlau I can't remember off hand, do we have any way to exclude tests specifically for OpenSSL 1.1.1? I'm guessing the existing excludes don't support that. We might be able to add excludes in the OpenSSL 1.1.1 job itself unless you have a better idea? |
@mhdawson tests can call
I'm not particularly keen on adding that burden onto the Jenkins admins to keep updated -- especially if that list will differ between Node.js versions. |
@richardlau ok so adding the common.hasOpenSSL3, common.hasOpenSS31 to the tests that need to be excluded would be your preference, right? |
I'd prefer that as then it will be picked up by downstream rebuilders/packagers (e.g. Linux distros). Anything we add to CI job configurations will not. |
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made. |
openssl 1.1.1 went EOL on September 11, as did node v16.
I don't think there's reason to keep the node-test-linux-linked-openssl111 and node-test-linux-linked-openssl111fips bots around and they've been problematic in at least one instance (nodejs/node#49712)
The text was updated successfully, but these errors were encountered: