-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup to publish benchmark results to nodejs.org #281
Comments
There's two approaches we could take here:
The nice thing about #2 is that we isolate the server more than if we make a new account that can be used. Personally I'd rather us keep non-build-core users off the server so the more we can do at a distance the better. Could the data be posted back to a GitHub repository that can be used as a basis for building the site? For context, this is how we do it with the website, nobody from the website group needs any kind of direct access and any activity performed by their scripting is done within a container so it's mostly isolated: https://github.com/nodejs/build/blob/master/setup/www/resources/scripts/build-site.sh#L36-L59 |
@rvagg you're right; the second approach is probably better. |
@rvagg just to confirm I understand. For 2 we'd publish the contents for benchmarking.nodejs.org to a specific directory in the nodejs/benchmarking repository on github which we'd update daily and then this would be automatically replicated onto the website. In this case we'd setup a public key so that change could be pushed from the benchmark machines to the nodejs/benchmarking repo on github, right ? If so, do we do anything special when setting that up or is it just a dummy github user (for example node-benchmarking) that we add and give access to the repo ? |
Ok so based on this and discussion with @jbergstroem I think the plan is to do the following:
This would allow the benchmark team to update the static www pages and also make the latest charts available on the www server for reference by those static pages. For more info on the planned overall flow/benchmarking infrastructure see https://github.com/nodejs/benchmarking/blob/master/benchmarks/README.md |
sounds good, let us know when this is ready to happen and we can generate an ssh keypair for it and get it rolling. |
@rvagg I'd like to get the mirroring going now as the graphs should have been generating for while and getting them onto the website even with the index will let us see them and provide the basis that we can start creating the index. |
Anything I can do to help on this one ? |
Have temporarily setup jobs to push to here http://nodejs.devrus.com:8080/
|
Done, I think. Server setup including 6-hourly sync (I don't know what "overnight" means tbh so this is will get it done!) plus github webhook for the benchmarking repo so when you update it there it'll get synced on the server and put in to place. https://benchmarking.nodejs.org/ You might want to ask |
Design? This is perfect! 🎉 |
@rvagg, Thanks, will do |
Issue in website WG repo here nodejs/nodejs.org#540. I think we can close this issue now. |
I've been doing some experimentation as described in this issue: nodejs/benchmarking#23
I'd like to get the required setup to publish benchmark graphs to nodejs.org, possibly using benchmarking.nodejs.org as the main entrypoint.
The machine generating the data will need to be able to push the graphs to nodejs.org on a nightly basis. Talking with @jbergstroem it sounds like we've done something similar and would set up a public key to be used to do the pushes.
The text was updated successfully, but these errors were encountered: