Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop testing with osx1014 (v17+, master)? #2769

Closed
targos opened this issue Sep 22, 2021 · 7 comments
Closed

Stop testing with osx1014 (v17+, master)? #2769

targos opened this issue Sep 22, 2021 · 7 comments

Comments

@targos
Copy link
Member

targos commented Sep 22, 2021

It started to fail with V8 9.5:
nodejs/node#40178
https://ci.nodejs.org/job/node-test-commit-osx/42171/nodes=osx1014/console

The build output suggests that Xcode 10 is used on those hosts, but Node.js requirements are now Xcode >=11.

@AshCripps
Copy link
Member

makes sense I had planned to add some intel big sur machines so I can just replace the 10.14 machines with them if there are no objections @nodejs/build?

@mhdawson
Copy link
Member

https://github.com/nodejs/node/blob/master/BUILDING.md#platform-list does say that we support 10.13 and above so we might want to have some 10.13 with the newer xcode or bump up the minimum macOS level for 17.x ?

@targos
Copy link
Member Author

targos commented Sep 22, 2021

we might want to have some 10.13 with the newer xcode

Xcode 11 doesn't support 10.13. It looks like some versions of it support 10.14: https://en.wikipedia.org/wiki/Xcode#11.x_series

@AshCripps
Copy link
Member

10.13 is our compilation target - it should be that our binaries will work on it but we dont compile on it.

@mhdawson
Copy link
Member

@AshCripps thanks for the reminder, makes sense. I remember discussions around that and we've been ok in past not testing on the lower versions so what you suggest seems good to me.

@targos
Copy link
Member Author

targos commented Oct 12, 2021

I don't know if it happened, but CI now passes with V8 9.5 so this is resolved from my PoV.

@AshCripps
Copy link
Member

@targos yep I dropped support in #2778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants