-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually flush cloudflare cache on release? #2396
Comments
It shows 14.7.0 now, but I'm 7h removed from this original comment so it'd be interesting to know how long that took if anyone happened to notice. There should be a maximum of a 5 minute delay for pushing a full CDN purge request to CF after someone promotes a build. I've now got logs so at least I can trace it! Here's the most recent:
The most interesting one is ~7h20m ago from when I'm writing this, there's two reasons given for a CDN purge, one is from builds being promoted (presumably the manual promotion) and the other from the signed checksums being pushed by the releaser, The timestamp on the signed SHASUMS is That log entry is done immediately prior to a @jbergstroem we're doing a |
Nope, this will zap everything. |
of course y'all are already doing it 😊. Does cloudflare have a similar "immediate" cache flush option as fastly does? I could imagine that we could make things a bit better by doing a more aggressive flush on particular routes... Specifically: |
It should be pretty immediate, I think the call goes out to invalidate all of the edges when we send it, at least that's how I've seen it work. The 5 minute delay is on our end for dedupe and security reasons. We've been discussing more selective flushes for a while now and there's enough awkwardness involved that we've yet to pull it off. But the timing would still be the same even when we get that implemented. |
Honestly 5 minutes is not the end of the world. We should just document it. |
FWIW, this is part reason I want to move all downloads to a subdomain: have better control of caching (#2375). |
I agree with @MylesBorins that 5 mins is not all that long |
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made. |
I've been noticing it taking quite a bit of time for new releases to propogate to the index For example we just released v14.7.0 and https://nodejs.org/download/release/latest-v14.x/ is still showing v14.6.0
My gut is this is related to our CDN cache, perhaps we should manually flush it on release?
The text was updated successfully, but these errors were encountered: