Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert node-test-commit-arm jenkins config to use select-compiler.sh #2279

Closed
sam-github opened this issue Apr 9, 2020 · 1 comment
Closed
Labels

Comments

@sam-github
Copy link
Contributor

https://ci.nodejs.org/job/node-test-commit-arm doesn't use

elif [ "$SELECT_ARCH" = "ARM64" ]; then
echo "Setting compiler for Node version $NODEJS_MAJOR_VERSION on arm64"
case $nodes in
centos7-arm64-gcc8 )
. /opt/rh/devtoolset-8/enable
echo "Compiler set to devtoolset-8"
;;
centos[67]-arm64-gcc6 )
. /opt/rh/devtoolset-6/enable
echo "Compiler set to devtoolset-6"
;;
esac
fi
, it has this in its configure:

else
  if [[ "$nodes" =~ centos[67]-(arm)?64-gcc8 ]]; then
    # temporary mesure to evaluate https://github.com/nodejs/node/issues/23913
    # REMOVEME at some point, see #23913 (RV, 22-10-19)
    # export CONFIG_FLAGS="$CONFIG_FLAGS --openssl-no-asm"
    exec_cmd=". /opt/rh/devtoolset-8/enable; $exec_cmd"
  fi
  
  if [[ "$nodes" =~ centos[67]-(arm)?64-gcc6 ]]; then
    # temporary mesure to evaluate https://github.com/nodejs/node/issues/23913
    # REMOVEME at some point, see #23913 (RV, 22-10-19)
    # export CONFIG_FLAGS="$CONFIG_FLAGS --openssl-no-asm"
    exec_cmd=". /opt/rh/devtoolset-6/enable; $exec_cmd"
  fi

  eval $exec_cmd
fi

It should use select-compiler.sh

@github-actions
Copy link

github-actions bot commented Feb 4, 2021

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Feb 4, 2021
@github-actions github-actions bot closed this as completed Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant