Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libuv: grant CI permissions to collaborator #2170

Closed
bnoordhuis opened this issue Feb 8, 2020 · 5 comments
Closed

libuv: grant CI permissions to collaborator #2170

bnoordhuis opened this issue Feb 8, 2020 · 5 comments

Comments

@bnoordhuis
Copy link
Member

I'm trying to add @erw7 to https://ci.nodejs.org/job/libuv-test-commit/configure but I can't get Jenkins to actually remember his entry. He should have the same permissions as @vtjnash.

@richardlau
Copy link
Member

Do they not fall under the already defined permissions for libuv?

@bnoordhuis
Copy link
Member Author

I believe that only applies to people in the core libuv team, not @libuv/windows.

@richardlau
Copy link
Member

richardlau commented Feb 8, 2020

I believe that only applies to people in the core libuv team, not @libuv/windows.

Ah right. I could add libuv*Collaborators?

Edit: added libuv*Collaborators with the same permissions as libuv.

@richardlau
Copy link
Member

According to https://ci.nodejs.org/user/erw7/ @erw7 is a member of:

Groups:

  • libuv
  • libuv*Collaborators
  • libuv*windows

so should have been covered by the existing libuv entry.

@bnoordhuis
Copy link
Member Author

I'll follow up with @erw7. Thanks for checking, Richard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants