Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ppcle-ubuntu1404? #2159

Closed
32 of 36 tasks
richardlau opened this issue Feb 4, 2020 · 7 comments
Closed
32 of 36 tasks

remove ppcle-ubuntu1404? #2159

richardlau opened this issue Feb 4, 2020 · 7 comments

Comments

@richardlau
Copy link
Member

richardlau commented Feb 4, 2020

We no longer build ppcle Linux releases on Ubuntu with the End-of-Life of Node.js 8:

[ /^ppcle-ubuntu/, releaseType, gte(10) ],

We test on centos7-ppcle for Node.js 10 onwards (i.e. all current supported Node.js versions). Time to retire ppcle-ubuntu1404 and remove from the CI? At the very least we could stop testing on it on the more recent release lines.

List of jobs to be updated on the public test CI based on https://github.com/nodejs/jenkins-config-test/ and the following shell script:

-bash-4.2$ grep ppcle-ubuntu1404 jobs/*  | awk -F'[/:]' '{ print "- [ ] "$2 }' | sort -u
  • citgm-abi-smoker-forward-compat.xml
  • citgm-abi-smoker.xml
  • citgm-continuous-integration.xml
  • citgm-smoker-nobuild.xml
  • citgm-smoker-pipeline.xml
  • citgm-smoker-private.xml
  • citgm-smoker-rebuild.xml
  • citgm-smoker-v10.x.xml
  • citgm-smoker-v12.x.xml
  • citgm-smoker.xml
  • citgm-smoker-yarn.xml
  • libuv-test-commit-linux.xml
  • llnode-continuous-integration.xml
  • llnode-pipeline.xml
  • node-inspect.xml
  • nodereport-continuous-integration-latest.xml
  • node-stress-single-test.xml
  • node-test-commit-plinux.xml
  • node-test-commit-v8-linux.xml
  • node-test-napi-modules-citgm-v8.x.xml
  • node-test-napi-modules-citgm.xml
  • node-test-node-addon-api-new.xml
  • node-test-node-addon-api.xml
  • readable-stream-continuous-integration.xml
  • readable-stream-pipeline.xml
  • string_decoder-continuous-integration.xml
  • string_decoder-pipeline.xml

release CI:

-bash-4.2$ grep ppcle-ubuntu1404 jobs/*  | awk -F'[/:]' '{ print "- [ ] "$2 }' | sort -u
  • iojs+release-joaocgreis.xml <-- job doesn't appear to exist anymore?
  • iojs+release-mdawson-major.xml
  • iojs+release-mdawson-osx.xml <-- job doesn't appear to exist anymore?
  • iojs+release-mdawson-test-centosppc.xml
  • iojs+release-mdawson-test.xml
  • iojs+release-new-osx-temp.xml <-- job doesn't appear to exist anymore?
  • iojs+release-ppcle-only.xml
  • iojs+release-sam-github.xml <-- job doesn't appear to exist anymore?
  • iojs+release.xml
@richardlau
Copy link
Member Author

cc @nodejs/platform-ppc

@sam-github
Copy link
Contributor

sam-github commented Feb 4, 2020

I think we should remove it. I went end-of-support in April 2019. The centos builds run on ubunt 1404, if anyone is running it, but we don't need it in CI.

@mhdawson
Copy link
Member

+1 to removing.

@richardlau
Copy link
Member Author

Via https://github.com/nodejs/jenkins-config-test/ here are the current references to ppcle-ubuntu1404:

-bash-4.2$ grep ppcle-ubuntu1404 jobs/*
jobs/citgm-abi-smoker-forward-compat.xml:        <string>ppcle-ubuntu1404</string>
jobs/citgm-abi-smoker.xml:        <string>ppcle-ubuntu1404</string>
jobs/citgm-continuous-integration.xml:        <string>ppcle-ubuntu1404</string>
jobs/citgm-smoker-nobuild.xml:        <string>ppcle-ubuntu1404</string>
jobs/citgm-smoker-pipeline.xml:debian8-64 fedora-last-latest-x64 fedora-latest-x64 osx1010 ppcle-ubuntu1404 ubuntu1404-64 ubuntu1604-64 rhel72-s390x aix61-ppc64
jobs/citgm-smoker-private.xml:        <string>ppcle-ubuntu1404</string>
jobs/citgm-smoker-rebuild.xml:        <string>ppcle-ubuntu1404</string>
jobs/citgm-smoker-v10.x.xml:        <string>ppcle-ubuntu1404</string>
jobs/citgm-smoker-v12.x.xml:        <string>ppcle-ubuntu1404</string>
jobs/citgm-smoker.xml:        <string>ppcle-ubuntu1404</string>
jobs/citgm-smoker-yarn.xml:        <string>ppcle-ubuntu1404</string>
jobs/libuv-test-commit-linux.xml:        <string>ppcle-ubuntu1404</string>
jobs/llnode-continuous-integration.xml:alpine-latest-x64 debian8-64 debian9-64 fedora-latest-x64 osx1010 ppcle-ubuntu1404 ubuntu1404-64 ubuntu1604-64 rhel72-s390x smartos16-64 smartos15-64 win10 win2012r2</description>
jobs/llnode-pipeline.xml:      debian8-64 fedora22 fedora23 osx1010 ppcle-ubuntu1404 ubuntu1404-64 ubuntu1604-64 rhel72-s390x aix61-ppc64 ppcbe-ubuntu1404 smartos16-64 smartos15-64 win10 win2012r2</description>
jobs/node-inspect.xml:          <description>Space-separated list of nodes, e.g. debian8-64 osx1010 ppcle-ubuntu1404 ubuntu1404-64 ubuntu1604-64 rhel72-s390x aix61-ppc64 smartos16-64 smartos15-64 win10 win2012r2</description>
jobs/node-inspect.xml:      description: &apos;Space-separated list of nodes, e.g. debian8-64 osx1010 ppcle-ubuntu1404 ubuntu1404-64 ubuntu1604-64 rhel72-s390x aix61-ppc64 smartos16-64 smartos15-64 win10 win2012r2&apos;,
jobs/nodereport-continuous-integration-latest.xml:        <string>ppcle-ubuntu1404</string>
jobs/node-stress-single-test.xml:        <string>ppcle-ubuntu1404</string>
jobs/node-test-commit-plinux.xml:        <string>ppcle-ubuntu1404</string>
jobs/node-test-commit-v8-linux.xml:        <string>ppcle-ubuntu1404</string>
jobs/node-test-napi-modules-citgm-v8.x.xml:        <string>ppcle-ubuntu1404</string>
jobs/node-test-napi-modules-citgm.xml:        <string>ppcle-ubuntu1404</string>
jobs/node-test-node-addon-api-new.xml:debian8-64 fedora-last-latest-x64 fedora-latest-x64 osx1010 ppcle-ubuntu1404 ubuntu1404-64 ubuntu1604-64 rhel7-s390x
jobs/node-test-node-addon-api-new.xml:        <string>ppcle-ubuntu1404</string>
jobs/node-test-node-addon-api.xml:debian8-64 fedora-last-latest-x64 fedora-latest-x64 osx1010 ppcle-ubuntu1404 ubuntu1404-64 ubuntu1604-64 rhel7-s390x
jobs/node-test-node-addon-api.xml:        <string>ppcle-ubuntu1404</string>
jobs/readable-stream-continuous-integration.xml:debian8-64 fedora-latest-x64 osx1010 ppcle-ubuntu1404 ubuntu1404-64 ubuntu1604-64 rhel72-s390x aix61-ppc64
jobs/readable-stream-pipeline.xml:alpine-latest-x64 debian8-64 fedora-latest-x64 osx1010 ppcle-ubuntu1404 ubuntu1404-64 ubuntu1604-64 rhel72-s390x aix61-ppc64
jobs/string_decoder-continuous-integration.xml:debian8-64 fedora-latest-x64 osx1010 ppcle-ubuntu1404 ubuntu1404-64 ubuntu1604-64 rhel72-s390x aix61-ppc64
jobs/string_decoder-pipeline.xml:alpine-latest-x64 debian8-64 fedora-latest-x64 osx1010 ppcle-ubuntu1404 ubuntu1404-64 ubuntu1604-64 rhel72-s390x aix61-ppc64
-bash-4.2$

@richardlau
Copy link
Member Author

Removed the above references (updating to centos7-ppcle where necessary). Need to sweep through any references in the release CI before updating VersionSelectorScript.groovy and the compiler selector -- needs access to the release Jenkins (which I might get under #2286).

@richardlau
Copy link
Member Author

Done the release CI jobs -- there appear to be jobs in the jenkins-config-release backup that are no longer in https://ci-release.nodejs.org/ and I'm presuming have been deleted.

@richardlau
Copy link
Member Author

Follow up PR to remove from select-compiler.sh and VersionSelectorScript.groovy scripts: #2292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants