Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Joyee to jenkins-admin? #2087

Closed
Trott opened this issue Dec 11, 2019 · 8 comments
Closed

add Joyee to jenkins-admin? #2087

Trott opened this issue Dec 11, 2019 · 8 comments

Comments

@Trott
Copy link
Member

Trott commented Dec 11, 2019

Doing some stuff with Joyee at Node+JS Interactive, and we set up a temporary job to test some stuff out, but I had to do it even though she knows more than me because I'm in jenkins-admin and she's not. I'd propose adding her, and also cleaning up some folks who haven't been around for a long time (Jon, George, insert joke about leaving Paul and Ringo in the team here).

@gireeshpunathil
Copy link
Member

+1

@joaocgreis
Copy link
Member

+1

cc @nodejs/jenkins-admins

@richardlau
Copy link
Member

+1

@rvagg
Copy link
Member

rvagg commented Dec 12, 2019

This is fine by me; but we have to do something about the many-hands problem across Jenkins because we're adding more hands. We're not coordinating or communicating very well and Jenkins doesn't provide any good mechanisms for doing that (and the history feature is mostly borked these days too!).
I keep on running in to strange behaviours configured in Jenkins that I can't find a reason for but are intentional. There's no paper-trail and it's hard to know if something's in place for a good reason or not. I'm likely doing a lot of this myself too so I'm not claiming to be blame free either (I'm probably even doing it to myself knowing how bad my memory for these kinds of details can be!).

I don't know what the answer is, but it probably starts with being more chatty here in the issue tracker about what we're doing when we're touching jobs that are managed by many people (the special purpose jobs aren't as concerning since there's generally one or two people).

@mhdawson
Copy link
Member

mhdawson commented Jan 6, 2020

+1

@sam-github
Copy link
Contributor

I don't have a problem giving access to credible people (like @joyeecheung , a long-time active collaborator and TSC member). +1 from me.

I think the question of tracking and documenting changes is an issue, but not directly related.

Maybe it should be in a seperate issue, but continuing here since its where we are: if Jenkins itself had a way of tracking and explaining config changes, that'd be ideal, though I haven't bumped into it (but I'm far from a Jenkins expert).

If its not a Jenkins featue, our options seem limited.

A github centric expectation would be that for any config change there should be an issue open that its related to, and perhaps there should be a config label applied to every issue that resulted in or is related to a jenkins config change.

I think this is pretty reasonable, but is not perfect:

  1. its hard to describe UI made changes in github issues, and screenshots are painful to make and not searchable
  2. the opposite flow, that @rvagg describes, is the one we want, wherein we get a git blame-like ability to look at something in the Jenkins UI, and then can somehow follow a trail back the github issue that motivated the change

@richardlau
Copy link
Member

+1 to the issue at hand (adding Joyee).

I've spun off the discussion about tracking changes to Jenkins to #2133.

@Trott
Copy link
Member Author

Trott commented Jan 21, 2020

I added Joyee. Closing. Thanks!

@Trott Trott closed this as completed Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants