Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tarball created on Mac throws errors when extracted on Linux #1658

Closed
MylesBorins opened this issue Jan 9, 2019 · 7 comments
Closed

Tarball created on Mac throws errors when extracted on Linux #1658

MylesBorins opened this issue Jan 9, 2019 · 7 comments

Comments

@MylesBorins
Copy link
Contributor

Cross post from nodejs/node#22805

I cc'd build without response

TL;DR we no longer have gnutar being used on OSX and it is causing errors. Fastest solution likely running brew install gnu-tar --with-default-names and using gnu-tar on our OSX systems

Anyone have time to look in to this?

@mhdawson
Copy link
Member

@gdams might be able to look at this, but he needs to get the additional AIX machine added first. We don't believe anything was changed other than moving to a new install.

If we start manually installing things it will just make it worse longer term. First we need to agree we should move to gnu-tar, then update the Ansibile scripts to install gnu-tar (can't remember if they have brew or not).

@mhdawson
Copy link
Member

More info, default tar version on old release machine:

release-requireio-osx1010-x64-1:~ iojs$ tar --version
bsdtar 2.8.3 - libarchive 2.8.3
release-requireio-osx1010-x64-1:~ iojs$

and on new release machine (OSX 10.11):

bsdtar 2.8.3 - libarchive 2.8.3

So looks like nothing changed from the version of tar being used.

Looking at the ansible files, at least brew is installed, but it is not immediately obvious how you would add installation of packaged with an option "--with-default-names" so it likely needs to wait until @gdams has time to look at it or somebody else can create a PR/test the needed updates to the Ansible files.

@gdams
Copy link
Member

gdams commented Jan 10, 2019

hmm yeah we'd need to double check a few things before making a change like that. Changing the tar in the path to be gnutar could have some unwanted repercussions.

@mscdex
Copy link

mscdex commented Feb 7, 2019

any update?

@MylesBorins
Copy link
Contributor Author

Ping ping ping ping ping

nodejs/node#22805

This is coming up again. Could we please change the tar version on these machines

@rvagg
Copy link
Member

rvagg commented Mar 12, 2019

let's switch to gnutar for 12+ eh? I think we can do that, it's available for osx if we want to continue doing it there and perhaps it's time to switch to a linux machine for the tarball creation jobs (including docs).

@rvagg
Copy link
Member

rvagg commented Apr 18, 2019

Calling this solved. As per, #1777, nightlies as of today use centos7 to generate all non-binary assets. This will apply to Node 12+. Older versions will stick with the current path.

@rvagg rvagg closed this as completed Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants