Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immediate failures on smartos, linux-containered, arm, and linuxone #1467

Closed
gabrielschulhof opened this issue Aug 20, 2018 · 7 comments
Closed

Comments

@gabrielschulhof
Copy link

https://ci.nodejs.org/job/node-test-pull-request/16595/
https://ci.nodejs.org/job/node-test-pull-request/16597/
https://ci.nodejs.org/job/node-test-pull-request/16602/
https://ci.nodejs.org/job/node-test-pull-request/16603/

On all of them, the above-mentioned platforms fail with "You have unstaged changes".

@cjihrig
Copy link
Contributor

cjihrig commented Aug 20, 2018

I'm not sure what caused it, but @joyeecheung left comments on a bunch of PRs last night saying to rebase the PR to make that go away. It worked for me.

@refack
Copy link
Contributor

refack commented Aug 20, 2018

The cause is a combination of old git versions and a bad commit (that was fixed nodejs/node#22340):
Ref: #1453

@gabrielschulhof
Copy link
Author

Thanks! I've rebased and will start a new CI.

@gabrielschulhof
Copy link
Author

Oh, I guess the REBASE_ONTO wasn't working because the repo wasn't clean.

@gabrielschulhof
Copy link
Author

Hmmm ... why does the linuxone sub-job list a whole pile of changes?

https://ci.nodejs.org/job/node-test-commit-linuxone/4181/

@refack
Copy link
Contributor

refack commented Aug 20, 2018

Hmmm ... why does the linuxone sub-job list a whole pile of changes?

ci.nodejs.org/job/node-test-commit-linuxone/4181

It's not an amazing feature. It compares the code to the last state of the workspace.

@gdams
Copy link
Member

gdams commented Aug 26, 2018

Closing as it this appears to have been resolved. Please re-open if the problem persists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants