doc,win: drop support for VS2017 to build Node.js core

nodejs · Jun 2, 2020 · 7f5c86c · 7f5c86c
1 parent 9cf3680
commit 7f5c86c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/doc/windows-visualstudio-supported-versions.md b/doc/windows-visualstudio-supported-versions.md
@@ -14,6 +14,7 @@ Supported versions for running the Node.js installer and executable as released.
 | v12             | 7 / 2008 R2                |
 | v13             | 7 / 2008 R2                |
 | v14             | 8.1 / 2012 R2              |
+| v15             | 8.1 / 2012 R2              |
 
 ## For building Node.js Core
 
@@ -25,6 +26,7 @@ Supported versions for building Node.js from source.
 | v12             | 2017, 2019 (flag) <sup>[8]</sup>    |
 | v13             | 2017, 2019 <sup>[9]</sup>           |
 | v14             | 2017, 2019                          |
+| v15             | 2019 <sup>[11]</sup>                |
 
 ## For building Node.js Addons
 
@@ -36,6 +38,7 @@ Supported versions for building Node.js addons. End-users should have one of the
 | v12             | 2015, VCBT2015, 2017, 2019 <sup>[10]</sup> |
 | v13             | 2015, VCBT2015, 2017, 2019                |
 | v14             | 2015, VCBT2015, 2017, 2019                |
+| v15             | 2015, VCBT2015, 2017, 2019                |
 
 ## Official Releases
 
@@ -47,6 +50,7 @@ These versions are used to build the official releases.
 | v12             | 2012 R2         | 2017                  |
 | v13             | 2012 R2         | 2017                  |
 | v14             | 2012 R2         | 2019                  |
+| v15             | 2012 R2         | 2019                  |
 
 ## References
 
@@ -60,3 +64,5 @@ These versions are used to build the official releases.
 10. Support for **building addons** with Visual Studio 2019 was added in v12.8.0 (node-gyp 5.0.0).
     - Pull Request: https://github.com/nodejs/node-gyp/pull/1762
     - Pull Request: https://github.com/nodejs/node/pull/28853
+11. Support for Visual Studio 2017 was removed in v15.0.0.
+    - Pull Request: https://github.com/nodejs/node/pull/33694
diff --git a/jenkins/scripts/VersionSelectorScript.groovy b/jenkins/scripts/VersionSelectorScript.groovy
@@ -62,7 +62,7 @@ def buildExclusions = [
   [ /vs2013(-\w+)?$/,                 testType,    gte(6)        ],
   [ /vs2015(-\w+)?$/,                 testType,    gte(10)       ],
   [ /vcbt2015(-\w+)?$/,               testType,    gte(10)       ],
-  [ /vs2017(-\w+)?$/,                 testType,    lt(8)         ],
+  [ /vs2017(-\w+)?$/,                 testType,    ltGte(8, 15)  ],
   [ /vs2019(-\w+)?$/,                 testType,    lt(13)        ],
   [ /vs2015-x86$/,                    testType,    gte(10)       ], // compile x86 only once
   [ /vs2017-x86$/,                    testType,    ltGte(10, 14) ],