Commit Queue

[MylesBorins]

The earliest I remember this being brought up was by @refack

A commit queue is a process for automating the landing of commits and managing of multiple branches.

This is a potential way to fix #2

For inspiration here is the design doc for the Chromium Commit Queue

The CQ polls rietveld for CLs that are ready to be committed. The Chromium's fork of Rietveld has a 'Commit' checkbox. When the author or the reviewer checks it, it will be included in the next poll. Once the CQ learns about the CL, it verifies the author or one of the reviewers approving this CL is a full committer, then runs the presubmit checks, then runs try jobs and then commit the patch on the behalf of the author, faking its credential. The whole project is written in python.

[joyeecheung]

The Rust project has a https://github.com/bors IIUC it pretty much does the same kind of stuff, but on Github. Pick a merged PR to see what it does.

[jasnell]

Until we have a consistently green and consistently functioning CI, this is going to be dang near impossible to do. There is too much in the landing process that requires manual intervention, not the least of which is interpreting CI results.

[MylesBorins]

@jasnell it could be kicked off only at the point you would manually do it yourself. That would remove the potential for error when landing the commit

[refack]

Refs: nodejs/build#705
There's seems to be prior art, I'll try to find references.

[bnoordhuis]

Until we have a consistently green and consistently functioning CI, this is going to be dang near impossible to do.

It's not a big deal in practice. Rust doesn't have that either, getting something landed sometimes takes a few retries, but it's okay because it's automated.

I for one would be very pleased if this went through.

[jasnell]

;) Ok... So long as it is focused on the after CI bits, I'm +1. Eventually we need to take a serious look at CI tho

[ofrobots]

If anything the commit queue increases the incentive to fix flakiness.

[joyeecheung]

Some thoughts on the next step of node-core-utils: https://github.com/joyeecheung/node-core-utils/issues/10 , could potentially be used by the bot, right now the goal is "good enough for human to use".