-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow
scope to github-bot token used on nodejs/node
#572
Comments
We've run into this for the docker-node PAT as well recently because they added GitHub Actions to their repo it creates PRs for. Can we piggy back this to make it a general "Add |
@nschonni create a new issue, since re-using this issue would require re-approval from folks who already approved. |
cc @nodejs/community-committee one more to go :) |
+1 |
@mmarchini Did this happen and can be closed? Or should this remain open? |
Done |
Why
The Commit Queue can't land changes to
.github/workflows
(see nodejs/node#34770 (comment)). That's because the Personal Access Token we use for Commit Queue doesn't have theworkflow
scope.Request
Add
workflow
scope to the Personal Access Token we use onnodejs/node
Potential risk
It shouldn't be more risky than using the Commit Queue without that scope. With that being said, someone should do an extra evaluation of risk before enabling this scope for the PAT.
The text was updated successfully, but these errors were encountered: