Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow scope to github-bot token used on nodejs/node #572

Closed
mmarchini opened this issue Nov 19, 2020 · 6 comments
Closed

Add workflow scope to github-bot token used on nodejs/node #572

mmarchini opened this issue Nov 19, 2020 · 6 comments
Labels
approved Request approved by TSC/CommComm

Comments

@mmarchini
Copy link
Contributor

Why

The Commit Queue can't land changes to .github/workflows (see nodejs/node#34770 (comment)). That's because the Personal Access Token we use for Commit Queue doesn't have the workflow scope.

Request

Add workflow scope to the Personal Access Token we use on nodejs/node

Potential risk

It shouldn't be more risky than using the Commit Queue without that scope. With that being said, someone should do an extra evaluation of risk before enabling this scope for the PAT.

@nschonni
Copy link
Member

We've run into this for the docker-node PAT as well recently because they added GitHub Actions to their repo it creates PRs for. Can we piggy back this to make it a general "Add workflow scope to github-bot", or is it better to spin up a new issue?

@mmarchini
Copy link
Contributor Author

@nschonni create a new issue, since re-using this issue would require re-approval from folks who already approved.

@mmarchini
Copy link
Contributor Author

cc @nodejs/community-committee one more to go :)

@bnb
Copy link
Contributor

bnb commented Dec 8, 2020

+1

@mmarchini mmarchini added the approved Request approved by TSC/CommComm label Dec 9, 2020
@Trott
Copy link
Member

Trott commented Dec 24, 2020

@mmarchini Did this happen and can be closed? Or should this remain open?

@mmarchini
Copy link
Contributor Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Request approved by TSC/CommComm
Projects
None yet
Development

No branches or pull requests

4 participants