Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES modules repo/team cleanup #513

Closed
Trott opened this issue Jun 18, 2020 · 22 comments
Closed

ES modules repo/team cleanup #513

Trott opened this issue Jun 18, 2020 · 22 comments

Comments

@Trott
Copy link
Member

Trott commented Jun 18, 2020

I'd like to archive https://github.com/nodejs/dynamic-modules. It seems inactive.

I'd also like to remove the modules-observers team. It seems to have served its purpose. As modules becomes less and less of an isolated strategic initiative and more and more something in core, an observers team seems less necessary.

I'll leave this open for at least 72 hours (and probably longer) for comments before doing anything.

@nodejs/tsc @nodejs/community-committee @nodejs/modules-active-members @nodejs/modules-observers

@zackschuster
Copy link

i'm a member of modules-observers. would i be able to transfer to a different team? i'd like to stick around :)

@giltayar
Copy link

You can take out the modules observer group, but you won't be able to stop me observing you! 😃

Thank you for the time spent as a member and as an (official) observer (and especially for @MylesBorins for inviting me to join). I learned a lot, and hopefully contributed some, even if just a little.

And kudos for the great work in delivering ESM to Node.js!

And, as a parting gift, here's a talk about ESM I gave at Node.TLV, a few days before the Covid-19 quarantine: https://www.youtube.com/watch?v=kK_3OP0uJ0Y. I believe this talk and the insight it gave the audience about the reasons for the decisions the WG took, would not have been possible if I had not been an observer.

@coreyfarrell
Copy link
Member

I don't have the bandwidth to enable notifications for the entire nodejs/node repository but membership in the modules-observers team gives me notifications I need. Maybe I should request transfer to the modules-active-members team but I think the modules-observers team still has a valid purpose.

@benjamingr
Copy link
Member

@giltayar knowing you: if you are interested and want to get involved in more areas including but not limited to:

  • Universal JavaScript (EventTarget/AbortController)
  • Streams and the (possible) new HTTP API
  • Promises UX
  • Docs
  • People engagement and CommComm

All those things could use help and of course - the modules team is still very much active and working on shipping ESM and I'm sure they'd love help. I am happy to help you get involved in any of these areas.

Of course, you are (probably) a busy person - so no pressure to get involved in any of these.

We are also always looking for more moderators for the moderation team :]


@coreyfarrell - just to make sure you realize, you are also a member of the tooling team so this change would likely have little impact org wise. In terms of modules-observers (as a member of that team) - what sort of notification would that be? IIRC that team just exists as a matter of governance (right?)

@coreyfarrell
Copy link
Member

@benjamingr I'm aware of my membership in the tooling team. As a member of modules-observers I receive notifications for any issue/PR tagged with @nodejs/modules.

@guybedford
Copy link
Contributor

Sounds good, thanks @Trott for the cleanup here.

Typically we only cc @nodejs/modules-active-members when writing a PR or modules issue. How are observers still getting notified for these? Or is this a special rule for labels?

@Trott
Copy link
Member Author

Trott commented Jun 30, 2020

I archived the dynamic-modules repo. Still have to figure out what to do with the team.

@zackschuster
Copy link

@guybedford we're auto-subscribed to a bunch of places, like moderation.

@Trott
Copy link
Member Author

Trott commented Jul 2, 2020

OK, someone else may make a different decision, but I'm going to leave the team, but remove folks who don't chime in about wanting to stay so that we don't have a long tail of inactive folks with access to the moderation repo, etc. If you haven't said anything in this thread and I've removed you and you want to get re-added, leave a comment in the next week or so.

@Trott
Copy link
Member Author

Trott commented Jul 2, 2020

(I'll also leave folks who are active on other teams.)

@Trott
Copy link
Member Author

Trott commented Jul 3, 2020

OK, all done! Closing but will repeat this bit:

If you haven't said anything in this thread and I've removed you and you want to get re-added, leave a comment in the next week or so.

@WebReflection
Copy link

So, I woke up with:

You’ve been removed from the modules-observers team on the Node.js organization.

and

You have been removed from the @Node.js organization

... were both necessary?

@Trott
Copy link
Member Author

Trott commented Jul 3, 2020

were both necessary?

Thanks for the feedback. Can you elaborate a bit? Is it that the email notifications arrived without an email explanation that this was happening? In other words, there was little context and it was impersonal. Or is it something else?

(Related: Did you want to be added back to the team?) I've sent an invitation for you to rejoin the team.

@benjamingr
Copy link
Member

@WebReflection feel free to ping me on Facebook (or via email) if you want to find other teams to get involved in. I think the project could benefit a lot from your contributions. Additionally if you are already involved with the work of another team you can be ask to be added back.

This was just a standard team clean-up, if you get removed from the last team you are a member of in GitHub it removes you from the org (I think so).

@Trott
Copy link
Member Author

Trott commented Jul 3, 2020

This was just a standard team clean-up, if you get removed from the last team you are a member of in GitHub it removes you from the org (I think so).

For that matter, modules-observers still exists and you're welcome to be added back to it. We're doing audits on a few teams right now. (Specifically, I'm doing one on platform-windows and there are other ones for jenkins-admins and various other builds groups.) There are a few reasons for pruning the group memberships. (The big one for me is access to private repos.)

This was just a standard team clean-up, if you get removed from the last team you are a member of in GitHub it removes you from the org (I think so).

It's not automatic (although you are far from alone in expecting that behavior!). That second step happens manually. I go through every few weeks or so and remove people who are on 0 teams from the org. At this point, it's a thing I've been doing for so long that I don't even think about why I do it anymore, and maybe I should re-evaluate that practice.

@bmacnaughton
Copy link

i'd like to be added-back/kept on the module-observers team. figuring out how to make our APM auto-instrumentation work with ES modules is my current focus.

our specific implementation monkey-patches the objects returned by the require function. i'm just starting to read months of backlog but is there any particular area where i can find a focus on that specific use case? issue nodejs/node#49452 is the closest i've found but there's a lot to look at. i'm probably missing others.

@bizob2828
Copy link

I’d also like to be added back to module observers.

@WebReflection
Copy link

@Trott @benjamingr thank you both, I didn't realize myself I was just module observer, hence my "reference counting" went down to zero after that. I know I haven't been too active recently but ... well, work / life happens, but I assure you I'm reading pretty much everything going on in there so ... thanks for adding me back, I'll try to contribute more in the near future 👋

@sendilkumarn
Copy link

sendilkumarn commented Jul 3, 2020

Hi @Trott & @benjamingr same here I was removed from the org but I would like to continue being part of the org and contribute.

If there is a possibility I would like to contribute toward the following teams

  • Streams and the (possible) new HTTP API
  • People engagement and CommComm

Thanks in advance🙂

@giltayar
Copy link

giltayar commented Jul 7, 2020

I’d also like to be added back to module observers.

@manekinekko
Copy link

manekinekko commented Jul 9, 2020

Hi @Trott & @benjamingr I was also removed from the org but I would like to continue being part of it. I have been away because of paternity leave. Would love to keep contributing to the Node community, if you folk still need help please let me know. Cheers.

@Trott
Copy link
Member Author

Trott commented Jul 9, 2020

I've re-added everyone who has commented.

@bmacnaughton Your invitation is still pending, which I think means you haven't accepted it in the GitHub interface? (The invitation for @manekinekko is pending too, but I just added it now.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests