Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 2 new repositories for build wg - jenkins config #464

Closed
mhdawson opened this issue Jan 23, 2020 · 9 comments
Closed

Create 2 new repositories for build wg - jenkins config #464

mhdawson opened this issue Jan 23, 2020 · 9 comments

Comments

@mhdawson
Copy link
Member

The build WG would like to get the ok to add 2 new repositories that we'll use to keep a history of the configuration of the jobs within jenkins.

The repos we want to create are:

  • jenkins-config-test
  • jenkins-config-release

More details on the plans are in: nodejs/build#2133

@Trott
Copy link
Member

Trott commented Jan 23, 2020

+1. FWIW, approval is not needed to create new repositories. Whoops, yes it is.

What teams will have write or admin access?

@Trott
Copy link
Member

Trott commented Jan 23, 2020

@nodejs/tsc @nodejs/community-committee

@sam-github
Copy link
Contributor

Initially, they will be private repos.

They will be readable by nodejs/build, and writable by a jenkins backup cron job.

Intention is that when we validate that no sensitive information is in the build job XML, they become public, readable by all, but only writable by the jenkins backup cron job.

@sam-github
Copy link
Contributor

+1

2 similar comments
@bnb
Copy link
Contributor

bnb commented Jan 27, 2020

+1

@joesepi
Copy link
Member

joesepi commented Jan 29, 2020

+1

@bnb
Copy link
Contributor

bnb commented Jan 29, 2020

Been 6 days with no -1s or -0s. I’d like to assert that these can go ahead and be created.

@mhdawson
Copy link
Member Author

@bnb agreed. Created the repositories.

@rvagg, @sam-github what teams should we give access to the repo?

I'm thinking maybe build for jenkins-config-test and build-infra for jenkins-config-release as a start?

We also need to likely add some user so that the automation can push the updates. What do we need to add for that?

@sam-github
Copy link
Contributor

I added @nodejs/jenkins-admins to nodejs/jenkins-config-test and @nodejs/jenkins-release-admins to nodejs/jenkins-config-release. Those are the groups that can already see the respective jenkins config right now, so it doesn't expose anything new.

@rvagg is in both, so he can add any other groups he deems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants