-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call with V8 #454
Comments
I'd like to propose the following additions to that list:
cc @mlippautz |
I think @bmeck would be interested in talking about a special parsing/execution mode for REPL, and perhaps about modules as well if there is anything. For that matter I’d be interested too but I’m not part of the TSC or a regular observer. |
I don't think anyone would mind if we invite both @bmeck and @TimothyGu |
I have an in-progress cmake branch that I should get merged but it's currently blocked on nodejs/build#1003. |
Even with the switch to cmake we would need a way for V8 to test against Node.js without having to maintain cmake configurations, so the GN wrapper still makes sense. |
Not sure if this is already documented somewhere, but I think having a more written down policy regarding support for VS2015 (is being dropped beginning in v10 IIRC?) would probably be good. IIRC, the change was related in part to things with V8 |
Count me in. Would love to see this happen again (and becoming a regular thing). One additional item I would add is a status update on trace event implementation, just so we can keep it on the radar. |
Sounds good to me. |
I'd like to attend as well. |
Does it make sense to schedule before or after a TSC meeting? I would assume that that would be more convenient for TSC members. |
We do have a calendar to schedule TSC meetings when everybody can attend, can we use the same system to schedule? What do you think @Trott? |
It's easy enough if we have the data. The challenge is getting everyone to enter data. Also, the TSC data is always for a Wednesday (UTC). Things get more difficult if you're talking about different days of the week. For ad hoc meetings like this, I think Doodle might be more appropriate. |
@hashseed . My experience is that its always a pain to try to schedule a time. What I'd suggest is a doodle to pick the first meeting and then make agree on a regular time slot. It's easier for people to remember and less work each time. Depending on who wants to attend though you might need to agree on a few slots and rotate. |
I can see the rational of trying to piggy back onto the TSC meeting, but it runs long often enough and even if it does not people may be fatigued having it right after an hour meeting. |
Okay. Assuming that most are located between Europe and West Coast, I chose european evenings and west coastal mornings for the Doodle: https://doodle.com/poll/d4ubsq5t6qczcdwm Let's agree on a suitable time before the January 19th. Thanks! |
I filled out the Doodle, but I'm no doubt the least important person to attend, so use me as a tie-breaker only. (Turns out my availability those days is rather scarce anyway.) |
I would like to know the future of workers in node.js. My co-workers and I have worked on this in recent moths to make workers in node.js much lighter. |
@aaronleeatali see https://github.com/nodejs/worker for some past discussion/work on this front. It would be great if you could comment on existing issues or open a new one there to share your use case and experience with workers. |
I would be interested in attending. |
It's not quite January 19th yet, but I'd like to propose the final choice, based on the Doodle outcome: January 31st, 7:15 PM Central European Time, 10:15 AM Pacific Time. |
Seems like I'll be one of the only two people to miss the meeting... oh well. I do have a class during that time |
@mhdawson Thanks. |
@TimothyGu sorry that the date doesn't suit you. I will take meticulous notes. |
Invitation has been sent. Let me know if I should extend it to more folks. |
@hashseed depending on how open it is, it would be great if @mmallick-ca, @jBarz could be invited. They work with me keeping our V8 ports up to date for s390 and PowerPC |
@mhdawson no objections here. I extended the invitation to both. |
@hashseed ... can you please include me on that as well? (I haven't seen an invitation come through so just want to make sure) |
I thought I already did. In any case I removed and readded you from the calendar event. |
Should we plan on streaming/recording this on YouTube? |
@fhinkel Recording this meeting would be great. I would definitely be interested in viewing this, but have been resisting piling on just to observe. Thank you. |
I have no idea how to stream to YouTube. Would anyone be willing to set it up? |
I created a youtube event. The main limitation is that I think we can only have ~10 people (although I think the limit might be 15 for our account). https://www.youtube.com/watch?v=Cg1jWTPAIDU is the link for those who want to watch. I'll post the link for participants a few minutes before the meeting (Same can be done by any "manager" of the Node.js youtube account) |
Even though I probably will not be there at the meeting, if possible I'd like to add to the agenda to talk about hooks in v8::Module that would allow more efficient deprecation of module exports. Much of the discussion began in nodejs/node#18131, but I'll summarize it below. Currently, Node.js uses self-hosted CJS files for implementation of core modules. To deprecate an export, we have two ways:
While option 1 still works with ES Modules, option 2 does not, since ES Modules' exports are not an object users can manipulate. But even with option 1, the current situation is not ideal, as an exported function may not always be called during development, thus preventing a developer from seeing the deprecation warning. Of course, we can just change properties to getter/setter function pairs that are each exported. However, with ESM, ideally we would have a chance to introspect a particular ES Module, and to emit a warning every time a deprecated binding gets imported. Better deprecation support is in fact recognized by some TSC members as an exit criterion of the ES Modules feature in Node.js. With the static/declarative nature of ESM syntax, this would be technically possible. Not only would this solve the problem of deprecating properties, but also provide more accurate reports of deprecated functions to users. Some open questions remain about what we should do with |
I accidentally used the meeting I had set up during the last benchmarking meeting. So new hangout. Link for those who just want to watch https://www.youtube.com/watch?v=4Fz6Tz9kb_s. Will post link for participants a few mins before meeting start.s |
Would it be possible to reorder the agenda items to have these first?
|
video call is full 😿 |
yes, what @ofrobots said |
Ditto. Unable to join. Can we please pick something other than hangouts with higher capacity |
Going to setup a zoom instead |
is this no longer going to be streamed? |
We are live on https://www.youtube.com/c/nodejs-foundation/live |
The video recording is still processing but I'll post here when it's done. |
Good thing you were recording because it looks like the zoom recording wasn't turned on :-) |
Youtube recording: https://youtu.be/a6YtLIaqMqs (Our stream settings are set to do archiving automatically.) |
@hashseed Think you could get us a link again to the clang presentation slides? I'd like to annotate the recording there. Unfortunately I was not set up to record the actual video (and didn't really even think about it due to how our regular meetings are). That discussion starts at https://youtu.be/a6YtLIaqMqs?t=47m4s for like 20mins. |
@Fishrock123 here's the clang presentation. |
I created a summary. |
We had a few calls to sync between what was the CTC and select people from the V8 team in the past, with good outcomes.
I'd like to propose another one in the second half of January.
Some agenda items I have in mind:
async_hooks
performance cliffsPromise
andasync
/await
performance considerations for Node 10cc @bmeurer @ajklein @ofrobots @fhinkel @mathiasbynens @natorion
Before I set up a Doodle, I'd like to get a feel for the general opinion on this.
The text was updated successfully, but these errors were encountered: