Allow collaborators to share Github Sponsors link in project readme #1552
Comments
|
SGTM |
|
+1 |
|
Question: Do we want to limit this to only Github Sponsors or are we going to allow others like buy me coffee, or patreon etc? |
|
I see no reason to limit to GitHub Sponsors only, but IMO it makes sense to not add more options until someone requests it |
|
I’m +1 of the idea, but I think we should add them to the website instead. |
|
Adding tsc-agenda for visibility and possible discussion |
Why not both? |
|
Why TSC members and not everyone listed on the README? It'd feel a bit weird to have a special treatment for us.
IIRC the TSC members are not listed on the website atm – if we add such list to the website, we should not forget about adding a bullet to the onboarding/offboarding document. |
I meant everyone, not specifically a portion of the organization. |
My bad! In that case, should we transfer this to nodejs/node? It seems it should not be a TSC decision. |
|
Doing it should fall on the TSC, I think we should approve it here before opening there. |
|
SGTM Adding it to the website and or the readme. |
|
SGTM, as I mentioned in the discussion in the TSC call, the proposal should define a standard way of presenting that link, e.g: use a plain html link with a text: (Sponsor me) linking to the collaborator-selected sponsor url. |
|
@anonrig the suggested next step was a PR in to the collaborator documentation. I think adding a section into https://github.com/nodejs/node/blob/main/doc/contributing/reconizing-contributors.md would make sense. From the discussion it sounded like it being very specific as outlined above in #1552 (comment) by @ruyadorno should be specififed, and that existing tooling would need to be updated to allow the added (Sponsor me) link. In terms of bikeshedding I think I prefer the name (Support me) for the visible name of the link. Would you like to create that PR? |
|
Also, it might be good to see what percentage of collaborators are interested in utilizing this. |
|
@tniessen do you have a suggestion for how we ask which collaborators would be interested. We could do that through a different issue, a discussion item, or maybe an at mention to all collaborators in the PR with the ask of how many people are interested? |
|
@mhdawson Not really. I probably would have just pinged the entire collaborators team to see how many people respond positively. (On the other hand, if people are in favor of this idea in any case, it might not be relevant to see if the broader collaborator group is interested.) |
|
@tniessen my thinking is that anything that we can do to support collaborators is good, provided there are no concerns in terms of impact to the project. |
|
I believe we should just take the time to consider the fact that this might create an incentive for collaborators to game the system in order to remain listed as a collaborator while not actively making contributions to the project. Being capable of effectively prune the list of collaborators was one of the points brought up during the conversation on nodejs/node#52459. |
|
Sorry to insist, but I don't see the TSC position on this topic could be different than "if Collaborators are onboard with the idea, that's great". Unless there's a lack of consensus among Collaborators, I don't see the point of discussing the issue here. |
|
@ruyadorno I can understand the concern, but I'd prefer that we optimize for supporting active collaborators versus trying to avoid inactive collaborators who stick around a bit longer. |
|
While I'm not opposed to the idea, I'm not sure if the project readme is the right place for it and we'd need some guidelines around it. For instance, each contributor should be limited to a single link at a maximum. That could be to a page where they choose to list multiple support options but the main link itself should be limited to just one. Second, if the link is going to be to specific sponsor services then it should be limited only to specific vetted services -- I don't want to get into a situation where someone posts a link to something like an onlyfans type of thing, etc. Third, the link itself should have specific display text like "(sponsor link)" or something equally generic and consistent. |
|
Another important thing to keep in mind is that Github Sponsors and other sponsorship services may not be available as an option for all Node.js contributors if they happen to live in a region where such services aren't provided. It's important to recognize that not all collaborators will be in a position to be able to take advantage of this. |
|
I would support only GitHub sponsors for now. |
|
@jasnell your points 1 and 3 were already discussed/agreed in the TSC meeting where it was discussed. The link needs to be standardized because there is tooling that validates the entries in the README.md. The second point was not discussed and its a good thing to discuss/agree on as we don't want what the links point to, to reflect badly on the project. Different people could be supported in different ways. For some financial sponsorship through GitHub sponsors or something else could makes sense. For others, it could be an ask that if they are a customer of where the person works for to let their the company know that they use Node.js. Just agreeing that we'll need some guidance on what is appropriate or not on the sponsor page. |
|
Related Next-10 discussion on funding, those interested in this issue thinking you may be interested in joinin the deep dive - nodejs/next-10#273 |
Refs: nodejs/TSC#1552 Signed-off-by: Michael Dawson <[email protected]>
|
PR as disccussed in last TSC meeting - nodejs/node#53312 |
Refs: nodejs/TSC#1552 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #53312 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
|
Landed in nodejs/node#53312 |
Refs: nodejs/TSC#1552 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #53312 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
|
I'm going to close this. @anonrig feel free to PR in your support link based on the guidelines. |
Refs: nodejs/TSC#1552 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #53312 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Refs: nodejs/TSC#1552 Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#53312 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Refs: nodejs/TSC#1552 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #53312 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Refs: nodejs/TSC#1552 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #53312 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
I propose adding github sponsors link in nodejs's readme next to TSC members, collaborators and triagers.
We don't have any funding options like Eslint or other large projects but this would give collaborators some incentive to continue their contributions.
I'd like to hear @nodejs/tsc's opinion before opening a PR.
The text was updated successfully, but these errors were encountered: