Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track backporting AsyncWrap changes #86

Closed
MylesBorins opened this issue Mar 10, 2016 · 4 comments
Closed

Track backporting AsyncWrap changes #86

MylesBorins opened this issue Mar 10, 2016 · 4 comments

Comments

@MylesBorins
Copy link
Contributor

There are quite a few commits that need to land to get LTS up to snuff for async wrap. Let's use this issue to track those and make sure we don't miss anything (especially fixes for regressions)

src: fix MakeCallback error handling nodejs/node#4507
http_parser: use MakeCallback nodejs/node#5419
src,http: fix uncaughtException miss in http nodejs/node#5591
async_wrap: add uid argument to all asyncWrap hooks nodejs/node#4600

@MylesBorins
Copy link
Contributor Author

We will also need to include nodejs/node@b72dbdb from nodejs/node#5233

@trevnorris
Copy link

Include nodejs/node#5756

@AndreasMadsen
Copy link
Member

nodejs/node#5756 has landed, can we do this now? As you can see from the issue references, I'm getting a few issues about the lack of/poor support for Node v4.

@MylesBorins
Copy link
Contributor Author

These have landed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@trevnorris @MylesBorins @AndreasMadsen and others