-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Truncating Pull Request text for large releases #670
Comments
I think(?) the benefit of pasting them in is for the mention/reference links in the individual PRs (like the '_ mentioned this pull request 16 days ago in v14.17.0 proposal' in nodejs/node#36755). I still tend to find those references quite useful. Maybe we could post commit lists that exceed the limit as separate comments? We could also consider hiding the longer commit lists under |
Yeah, I can investigate this and maybe modify guides for noticeable issues. I'll follow up. |
Made a PR for this here: nodejs/node#39186 |
Fixed in nodejs/node@223625a |
The Changelog that had been copy and pasted to the PR description for v14.17.0 here was extensive. Presumably, because of this, comments were getting lost, and it became difficult to update the PR the description.
Could we truncate the Changelog for large releases to ensure comments don't get lost? Or is the Changelog important enough that we want the entirety of the text there?
The text was updated successfully, but these errors were encountered: